Various Fixes in the defaults for classify#13
Open
rTreutlein wants to merge 1 commit intoActivityWatch:masterfrom
Open
Various Fixes in the defaults for classify#13rTreutlein wants to merge 1 commit intoActivityWatch:masterfrom
rTreutlein wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
ErikBjare
requested changes
Apr 17, 2019
Member
ErikBjare
left a comment
ErikBjare
left a comment
There was a problem hiding this comment.
Nice changes, but breaks Travis and has some issues I'd like to get fixed before I merge it.
| events = exclude_keyvals(events, "app", browsernames_chrome) | ||
| events = exclude_keyvals(events, "app", browsernames_ff) | ||
| events = concat(events, events_web_ff) | ||
| events = concat(events, events_web) |
| @@ -423,7 +425,7 @@ def test_union_no_overlap(): | |||
| def get_events(since: datetime, end: datetime, include_smartertime='auto', include_toggl=None) -> List[Event]: | |||
Member
There was a problem hiding this comment.
Better to change include_smartertime='auto' to False than to pass it in the call on line 542.
| how_far_back = timedelta(hours=1 * 24) | ||
| args.start = args.end - how_far_back | ||
| events = get_events(args.start, args.end, include_toggl='./data/private/Toggl_time_entries_2017-12-17_to_2018-11-11.csv') | ||
| events = get_events(args.start, args.end, False) |
Member
There was a problem hiding this comment.
This was the False I was referring to.
| @@ -0,0 +1 @@ | |||
| regex;sub-category;category | |||
Member
There was a problem hiding this comment.
Keep the default categories and add a comment specifying the format instead.
The file name should still be categories.example.csv, correct the filename used in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #12 here my various fixes and i found one more issue where data from Chromium was completely dropped.