Skip to content

feat: fix a11y issues in tree select and tree autocomplete components #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fateeand merged 16 commits into from
Jun 25, 2026
Merged

feat: fix a11y issues in tree select and tree autocomplete components #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8c3eff2
fixing ally issues in CpsTreeSelectComponent
fateeand Jun 17, 2026
5d2c389
update tree autocomplete page
fateeand Jun 17, 2026
c8c5f66
Merge branch 'master' into 600-fix-a11y-issues-in-tree-select-component
fateeand Jun 17, 2026
fb4620b
more to prev
fateeand Jun 17, 2026
8a304b4
fix tree autocomplete
fateeand Jun 18, 2026
a011187
fix outer div click
fateeand Jun 18, 2026
3946674
fix icons positioning
fateeand Jun 18, 2026
103f0bb
fix focus rings size
fateeand Jun 18, 2026
163d218
get rid of duplicated input
fateeand Jun 18, 2026
3790863
add onContainerMouseDown
fateeand Jun 18, 2026
bfbf76c
add toggle node arialabel
fateeand Jun 18, 2026
628361f
add UTs
fateeand Jun 18, 2026
94dbfaf
fix no items list in virtual scroll case
fateeand Jun 18, 2026
f8584a7
Merge branch 'master' into 600-fix-a11y-issues-in-tree-select-component
fateeand Jun 18, 2026
5dc7207
address feedback from copilot
fateeand Jun 19, 2026
b0582c2
Merge branch 'master' into 600-fix-a11y-issues-in-tree-select-component
fateeand Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions playwright/cps-accessibility.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,25 +242,25 @@ const components: ComponentEntry[] = [
await page.waitForSelector('.example-content');
await page.locator('.example-content cps-button').first().hover();
}
},
{
route: '/tree-autocomplete',
name: 'Tree autocomplete',
selector: ['cps-tree-autocomplete', '.cps-treeautocomplete-options-menu'],
setup: async (page) => {
await page.waitForSelector('cps-tree-autocomplete');
await page.locator('cps-tree-autocomplete').first().click();
}
},
{
route: '/tree-select',
name: 'Tree select',
selector: ['cps-tree-select', '.cps-treeselect-options-menu'],
setup: async (page) => {
await page.waitForSelector('cps-tree-select');
await page.locator('cps-tree-select').first().click();
}
}
// {
// route: '/tree-autocomplete',
// name: 'Tree autocomplete',
// selector: ['cps-tree-autocomplete', '.cps-treeautocomplete-options-menu'],
// setup: async (page) => {
// await page.waitForSelector('cps-tree-autocomplete');
// await page.locator('cps-tree-autocomplete').first().click();
// }
// },
// {
// route: '/tree-select',
// name: 'Tree select',
// selector: ['cps-tree-select', '.cps-treeselect-options-menu'],
// setup: async (page) => {
// await page.waitForSelector('cps-tree-select');
// await page.locator('cps-tree-select').first().click();
// }
// },
// { route: '/tree-table', name: 'Tree table', selector: 'cps-tree-table' }
];

Expand Down
10 changes: 9 additions & 1 deletion projects/composition/src/app/api-data/cps-tree-autocomplete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@
"default": "",
"description": "Label of the component."
},
{
"name": "ariaLabel",
"optional": false,
"readonly": false,
"type": "string",
"default": "",
"description": "Aria label for accessibility, takes precedence over label."
},
{
"name": "hint",
"optional": false,
Expand Down Expand Up @@ -146,7 +154,7 @@
"optional": false,
"readonly": false,
"type": "iconSizeType",
"default": "18px",
"default": "1.125rem",
"description": "Size of icon before input value, of type number, string, 'fill', 'xsmall', 'small', 'normal' or 'large'."
},
{
Expand Down
10 changes: 9 additions & 1 deletion projects/composition/src/app/api-data/cps-tree-select.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@
"default": "",
"description": "Label of the component."
},
{
"name": "ariaLabel",
"optional": false,
"readonly": false,
"type": "string",
"default": "",
"description": "Aria label for accessibility, takes precedence over label."
},
{
"name": "hint",
"optional": false,
Expand Down Expand Up @@ -138,7 +146,7 @@
"optional": false,
"readonly": false,
"type": "iconSizeType",
"default": "18px",
"default": "1.125rem",
"description": "Size of icon before input value, of type number, string, 'fill', 'xsmall', 'small', 'normal' or 'large'."
},
{
Expand Down
10 changes: 9 additions & 1 deletion projects/composition/src/app/api-data/internal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@
"default": "",
"description": "Label of the component."
},
{
"name": "ariaLabel",
"optional": false,
"readonly": false,
"type": "string",
"default": "",
"description": "Aria label for accessibility, takes precedence over label."
},
{
"name": "hint",
"optional": false,
Expand Down Expand Up @@ -122,7 +130,7 @@
"optional": false,
"readonly": false,
"type": "iconSizeType",
"default": "18px",
"default": "1.125rem",
"description": "Size of icon before input value, of type number, string, 'fill', 'xsmall', 'small', 'normal' or 'large'."
},
{
Expand Down
4 changes: 2 additions & 2 deletions ...ts/composition/src/app/pages/tree-autocomplete-page/tree-autocomplete-page.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@
<div class="sync-val-example">
<cps-tree-autocomplete
[initialExpandDirectories]="true"
width="500"
width="31.25rem"
label="Single tree autocomplete with two-way binding, enter something"
hint="This tree autocomplete has a fixed width of 500px"
hint="This tree autocomplete has a fixed width of 31.25rem"
[options]="options"
optionInfo="attrType"
optionLabel="label"
Expand Down
4 changes: 2 additions & 2 deletions ...ts/composition/src/app/pages/tree-autocomplete-page/tree-autocomplete-page.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.tree-autocompletes-group {
gap: 24px;
gap: 1.5rem;
display: flex;
flex-direction: column;
}
Expand All @@ -8,6 +8,6 @@
display: flex;
align-items: center;
.sync-val {
margin-left: 24px;
margin-left: 1.5rem;
}
}
4 changes: 2 additions & 2 deletions projects/composition/src/app/pages/tree-select-page/tree-select-page.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@
<div class="sync-val-example">
<cps-tree-select
[initialExpandDirectories]="true"
width="500"
width="31.25rem"
label="Single tree select with two-way binding, select something"
hint="This tree select has a fixed width of 500px"
hint="This tree select has a fixed width of 31.25rem"
[options]="options"
optionInfo="attrType"
optionLabel="label"
Expand Down
4 changes: 2 additions & 2 deletions projects/composition/src/app/pages/tree-select-page/tree-select-page.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.tree-selects-group {
gap: 24px;
gap: 1.5rem;
display: flex;
flex-direction: column;
}
Expand All @@ -8,6 +8,6 @@
display: flex;
align-items: center;
.sync-val {
margin-left: 24px;
margin-left: 1.5rem;
}
}
Loading
Loading