-
Notifications
You must be signed in to change notification settings - Fork 0
Add status change topic #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
717fddb
f607b58
2093de9
a6dc8b4
0c8deb2
c6e6750
bd315a3
b3f9e9a
f2d7278
84f9b24
12de355
1a0c431
c39269c
c215254
2660b82
eb46390
1726ecf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "python.testing.pytestArgs": [ | ||
| "tests" | ||
| ], | ||
| "python.testing.unittestEnabled": false, | ||
| "python.testing.pytestEnabled": true | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,293 @@ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "event_type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "JobCreatedEvent", | ||
| "JobCreatedAndStartedEvent", | ||
| "JobStartedEvent", | ||
| "JobUpdatedEvent", | ||
| "JobFinishedEvent" | ||
| ], | ||
| "description": "Lifecycle event type for job status changes." | ||
| }, | ||
| "event_id": { | ||
| "type": "string", | ||
| "format": "uuid", | ||
| "description": "Unique identifier for the event (UUID)" | ||
| }, | ||
| "job_ref": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "Identifier of the job in it's respective system (e.g. Spark Application Id, Glue Job Id, EMR Step Id, etc)." | ||
| }, | ||
| "tenant_id": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "Application ID or ServiceNow identifier" | ||
| }, | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| "source_app": { | ||
| "type": "string", | ||
| "description": " Standardized source application name (aqueduct, unify, lum, etc)" | ||
| }, | ||
| "source_app_version": { | ||
| "type": "string", | ||
| "description": "Source application version (SemVer preferred)" | ||
| }, | ||
| "environment": { | ||
| "type": "string", | ||
| "description": "Environment (dev, uat, pre-prod, prod, test or others)" | ||
| }, | ||
| "timestamp_event": { | ||
| "type": "integer", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, number can also be floating point, so integer is the correct choice here. However, your call, rather be consistent but wrong, or eventually fix it in the runs schema as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about this one more time and I prefer correctness over consistency. Let's fix the other schemas later: #163 - this is hopefully a quick and painless fix, as the number -> integer should be backward compatible |
||
| "minimum": 0, | ||
| "description": "Timestamp of the event in epoch milliseconds" | ||
| }, | ||
|
kevinwallimann marked this conversation as resolved.
|
||
| "country": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "The country the data is related to, e.g. za, ke, on-mu, nbc-tz, etc." | ||
| }, | ||
| "job_id": { | ||
| "type": "string", | ||
| "format": "uuid", | ||
| "description": "Primary job identifier (UUID)." | ||
| }, | ||
| "parent_job_id": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "format": "uuid", | ||
| "description": "Optional parent job identifier (UUID), to represent nested job hierarchies." | ||
| }, | ||
| "initial_job_id": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "format": "uuid", | ||
| "description": "Optional initial job identifier (UUID), to represent retried or replayed jobs." | ||
| }, | ||
| "job_group_id": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "format": "uuid", | ||
| "description": "Job group identifier (UUID), may or may not reference a job id." | ||
| }, | ||
| "job_name": { | ||
| "type": "string", | ||
| "description": "Human-readable job name." | ||
| }, | ||
| "attempt_number": { | ||
| "type": [ | ||
| "integer", | ||
| "null" | ||
| ], | ||
| "minimum": 1, | ||
| "description": "Attempt number for this job." | ||
| }, | ||
| "platform": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "Platform, e.g. aws.emr, aws.glue, aws.lambda." | ||
| }, | ||
| "platform_metadata": { | ||
| "type": [ | ||
| "object", | ||
| "null" | ||
| ], | ||
| "description": "Platform-specific metadata (e.g. {\"cluster_id\": \"j-...\"})." | ||
| }, | ||
| "input_arguments": { | ||
| "type": [ | ||
| "object", | ||
| "null" | ||
| ], | ||
| "description": "Arguments passed to the job." | ||
| }, | ||
| "definition_id": { | ||
| "type": "string", | ||
| "description": "Definition (Pipeline, Domain, Process) identifier." | ||
| }, | ||
| "definition_version": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "Optional definition version." | ||
| }, | ||
| "status_type": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "enum": [ | ||
| "WAITING", | ||
| "RUNNING", | ||
| "SUCCEEDED", | ||
| "FAILED", | ||
| "KILLED", | ||
| null | ||
| ], | ||
| "description": "High-level status type for the current lifecycle event." | ||
| }, | ||
| "status_subtype": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "Optional status subtype, e.g. NO_DATA or error code." | ||
| }, | ||
| "status_detail": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "description": "Optional human-readable status detail, e.g. short error message." | ||
| }, | ||
| "additional_context": { | ||
| "type": [ | ||
| "object", | ||
| "null" | ||
| ], | ||
| "description": "Additional context payload." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "event_type", | ||
| "event_id", | ||
| "job_id", | ||
| "status_type" | ||
| ], | ||
| "allOf": [ | ||
| { | ||
| "if": { | ||
| "properties": { | ||
| "event_type": { | ||
| "enum": [ | ||
| "JobCreatedEvent" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "then": { | ||
| "required": [ | ||
| "job_name", | ||
| "source_app", | ||
| "source_app_version", | ||
| "timestamp_event", | ||
| "environment", | ||
| "definition_id", | ||
| "platform", | ||
| "input_arguments" | ||
| ], | ||
| "properties": { | ||
| "status_type": { | ||
| "enum": [ | ||
| "WAITING" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "if": { | ||
| "properties": { | ||
| "event_type": { | ||
| "enum": [ | ||
| "JobCreatedAndStartedEvent" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "then": { | ||
| "required": [ | ||
| "job_name", | ||
| "source_app", | ||
| "source_app_version", | ||
| "timestamp_event", | ||
| "environment", | ||
| "definition_id", | ||
| "platform", | ||
| "input_arguments" | ||
| ], | ||
| "properties": { | ||
| "status_type": { | ||
| "enum": [ | ||
| "RUNNING" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "if": { | ||
| "properties": { | ||
| "event_type": { | ||
| "const": "JobStartedEvent" | ||
| } | ||
| } | ||
| }, | ||
| "then": { | ||
| "properties": { | ||
| "status_type": { | ||
| "enum": [ | ||
| "RUNNING" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "if": { | ||
| "properties": { | ||
| "event_type": { | ||
| "const": "JobUpdatedEvent" | ||
| } | ||
| } | ||
| }, | ||
| "then": { | ||
| "properties": { | ||
| "status_type": { | ||
| "enum": [ | ||
| "WAITING", | ||
| "RUNNING" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "if": { | ||
| "properties": { | ||
| "event_type": { | ||
| "const": "JobFinishedEvent" | ||
| } | ||
| } | ||
| }, | ||
| "then": { | ||
| "properties": { | ||
| "status_type": { | ||
| "enum": [ | ||
| "SUCCEEDED", | ||
| "FAILED", | ||
| "KILLED" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,7 @@ | |
| TOPIC_RUNS = "public.cps.za.runs" | ||
| TOPIC_DLCHANGE = "public.cps.za.dlchange" | ||
| TOPIC_TEST = "public.cps.za.test" | ||
| TOPIC_STATUS_CHANGE = "public.cps.za.status_change" | ||
|
|
||
| SUPPORTED_WRITE_TOPICS: frozenset[str] = frozenset({TOPIC_RUNS, TOPIC_DLCHANGE, TOPIC_TEST}) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing the status_change topic in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm also there is no addition of this new queue in |
||
| SUPPORTED_STATS_TOPICS: frozenset[str] = frozenset({TOPIC_RUNS}) | ||
Uh oh!
There was an error while loading. Please reload this page.