ci: remove the false pipefail comment that reached main - #129
Merged
Conversation
My retraction commit did not land before #128 was squashed, so the merge carried the PRE-retraction state and put a comment on main asserting a bug that does not exist. That is precisely what I said I would least like to ship, in a PR about false claims, and I merged it myself without re-checking that the force-push had arrived. The comment claimed `shell: bash` runs `bash -e` without pipefail. It is the reverse: shell: bash -> bash --noprofile --norc -eo pipefail {0} no shell key (default) -> bash -e {0} The explicit form, which reads like a no-op, is the one that ADDS pipefail. This step has it, so the macOS harness pipe never swallowed cargo's status and those greens were always valid evidence. The now-redundant `set -o pipefail` goes with it. Replaced by a comment recording which form supplies pipefail and that a commit briefly claimed the opposite, so the next reader inherits the correction rather than the inference. The warning-ratchet fixes from #128 are unaffected and stay: `|| true` discards a compile failure regardless of pipefail, and a missing baseline became a ceiling nothing could exceed. PROCESS NOTE: verify a force-push landed before merging a PR you amended. `gh pr merge` will happily squash whatever the remote actually holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment asserting a bug that does not exist is on main, and I put it there.
My retraction commit did not land before #128 was squashed, so the merge carried the pre-retraction state. I merged it myself without re-checking that the force-push had arrived. That is exactly what I said I would least like to ship, inside a PR about false claims.
What the comment claimed, and why it is wrong
It said
shell: bashrunsbash -ewithout pipefail. The reverse is true:The explicit form, which reads like a no-op, is the one that adds pipefail. This step has it. So the macOS harness pipe never swallowed cargo's status, and those greens were always valid evidence — for #83, #113, #118, #119 and #122.
The now-redundant
set -o pipefailgoes with the comment. In its place: a note recording which form supplies pipefail and that a commit briefly claimed the opposite, so the next reader inherits the correction rather than repeating the inference. Refuted by claude-advisor and verified against GitHub's own workflow-syntax documentation before writing this.What stays
#128's warning-ratchet fixes are untouched and remain real, because neither depends on pipefail:
cargo check ... | grep "^warning:" > file || trueexplicitly discards the status, so a tree that does not compile still scores zero warnings and passes the ratchet..github/warning-baselinebecame9999, a ceiling nothing could exceed, silently turning the gate off.That step has no
shell:key, so it genuinely runs the bare default without pipefail, and itsset -o pipefailis correct and stays.Process note
Verify a force-push landed before merging a PR you amended.
gh pr mergewill squash whatever the remote actually holds, not what your local branch says. The amend and the merge were minutes apart and I checked neither.