fix(app-webdir-ui): hide social media list when profile has no social links#1747
Open
juanmitriatti wants to merge 1 commit into
Open
fix(app-webdir-ui): hide social media list when profile has no social links#1747juanmitriatti wants to merge 1 commit into
juanmitriatti wants to merge 1 commit into
Conversation
… links The Web Directory profile card rendered an empty ul.person-social-medias when the profile had a bio but no social media or website links (accessibility issue: screen readers announce an empty list). - ProfileCard: the list only renders when at least one of facebook/linkedin/twitter/website links exists - PersonProfile (unity-react-core): same guard; also prevents a crash when the optional socialMedia prop is undefined
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1747/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accessibility fix (JSM "Web Directory - hdasoa"): profiles without social media or website links rendered an empty
<ul class="person-social-medias"></ul>. The list now only renders when there is at least one icon to show.Changes
ProfileCard:hasSocialLinkscheck (facebook/linkedin/twitter/website) wraps theulPersonProfile: same guard; also prevents a crash whensocialMediais undefinedTesting
ul; one link →ulwith oneli; empty/undefinedsocialMedia→ noul