docs(vertex): pass model to from_genai#2442
Open
coyaSONG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Correct the Vertex AI migration example so
modelis passed to Instructor'sfrom_genaihelper instead ofgoogle.genai.Client.This matches the two APIs: the Google client configures the Vertex AI connection, while Instructor uses
modelas the default model for requests.Closes #2416.
Issue ticket number and link
Verification
ast.parsegoogle-genaiv1.31.0Clientsignature does not acceptmodelfrom_genaihelper acceptsmodelgit diff --checkChecklist before requesting a review
This PR was prepared with OpenAI Codex.