Skip to content

rpc: fix eth_subscribe logs with topic filters to preserve wildcard p… #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mukul3097 wants to merge 1 commit into
base: release/3.2-develop
Choose a base branch
from
Open

rpc: fix eth_subscribe logs with topic filters to preserve wildcard p… #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rpc/rpchelper/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,11 @@ func (ff *Filters) SubscribeLogs(size int, criteria filters.FilterCriteria) (<-c
break
}
}
if len(allowedTopicsRow) > 0 {
allowedTopics = append(allowedTopics, allowedTopicsRow)
}
// BUG FIX: Removed guard that was dropping empty topic rows (wildcards)
// This was causing eth_subscribe with topic filters to return no events
// because wildcard positions (empty arrays) were being skipped, causing
// positional misalignment in topic matching
allowedTopics = append(allowedTopics, allowedTopicsRow)
}
f.topicsOriginal = allowedTopics
}
Expand Down
Loading