Skip to content

chore: block subscription, deactivate actors#2120

Open
SantiagoPittella wants to merge 1 commit into
nextfrom
santiagopittella-ntx-builder-block-sub-phase-1
Open

chore: block subscription, deactivate actors#2120
SantiagoPittella wants to merge 1 commit into
nextfrom
santiagopittella-ntx-builder-block-sub-phase-1

Conversation

@SantiagoPittella
Copy link
Copy Markdown
Collaborator

@SantiagoPittella SantiagoPittella commented May 22, 2026

This PR:

  • Removes the NtxBuilder proto api.
  • Refactors the Ntx Builder to use a BlockSubscription instead of a mempool one.
  • Temporary deactivates the actors.
  • Streams the blocks until sync and marks is_synced to true when reached, after that it cointinues fetching and updating the local tip.

Caution

This change halts the execution of network transactions

@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-ntx-builder-block-sub-phase-1 branch from 4e84942 to 3e73be1 Compare May 22, 2026 18:28
@SantiagoPittella SantiagoPittella added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label May 22, 2026
@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-ntx-builder-block-sub-phase-1 branch from 3e73be1 to 46170b5 Compare May 22, 2026 18:33
@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-ntx-builder-block-sub-phase-1 branch from 46170b5 to 8da5828 Compare May 22, 2026 18:44
@igamigo
Copy link
Copy Markdown
Collaborator

igamigo commented May 22, 2026

Would it make sense to build this on top of #2095 considering #2095 (review)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants