Skip to content

Optionally, skip Bitcoin Core version check #107

Description

@0xB10C

fork-observer/src/main.rs

Lines 780 to 786 in a6e2956

async fn load_node_version(node: BoxedSyncSendNode, network: &str) -> String {
// The Bitcoin Core version is requested via the getnetworkinfo RPC. This
// RPC exposes sensitive information to the caller, so it might not be
// allowed on the whitelist. We set the version to VERSION_UNKNOWN if we
// can't request it. As RPC interface might not be up yet, we
// try to request the version multiple times.
let mut interval = interval(Duration::from_secs(10));

These 5x 10s are hardcoded. Would be good to be able to skip this via a node configuration option if we know this version information isn't available.

I could use this to speed up the peer-observer-infrastructure integration tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions