Add models for Zivid 3 XL250 - #169
Conversation
|
@johningve Would you mind to have a look? Thanks a lot! |
|
Hi @feuerste! Thanks for the contribution. The diff looks good to me, I'll just need a little time to take a look at the files first before I merge this. |
Thanks @johningve github even seems to have an embedded stl viewer. If you go directly to e.g. https://github.com/feuerste/zivid-ros/blob/zivid_3_meshes/zivid_description/meshes/visual/zivid_3.stl, you will see the model :) |
|
@johningve Did you have a chance to look into the models? Thanks a lot! |
|
@johningve Can I help you in any way, e.g. by providing the models in a different format? Thanks again for taking the time to look into this! |
Each FOV mesh has a sphere indicating the focus point of the camera. The XL250's FOV mesh placed the focus point at 2m along the optical axis, but the correct position is at 2.5m. This commit translates the sphere to the correct position.
johningve
left a comment
johningve
left a comment
There was a problem hiding this comment.
Sorry for taking so long. I have taken a look at all the files and they look good. I found one error in the FOV mesh, which I pushed a commit to fix: The mesh has a sphere indicating the focus point, and that was at the wrong position.
Thanks for the contribution!
|
@johningve Thanks a lot, also for the fix! How can we trigger the checks, so we can merge? |
|
I see that I screwed up the CI for external contributors in f693d7b to fix it triggering twice on feature branches. I will just merge this PR manually and then fix the workflow trigger afterwards. |
3 participants
The models have been downloaded from the zivid website and simplified to roughly match the resolution of the already existing Zivid 2 models.