diff --git a/interfaces/connect.ts b/interfaces/connect.ts index da29877..9a93745 100644 --- a/interfaces/connect.ts +++ b/interfaces/connect.ts @@ -462,13 +462,13 @@ export interface Order { * This interface defines the parameters required to retrieve historical data. * * @public - * @name getHistoricalDataParams + * @name GetHistoricalDataParams */ -export interface getHistoricalDataParms { +export interface GetHistoricalDataParams { /** * @type {string} */ - instrument_token: string; + instrument_token: string | number; /** * @type {string} */ @@ -484,11 +484,11 @@ export interface getHistoricalDataParms { /** * @type {?boolean} */ - continuous?: boolean; + continuous?: boolean | number; /** * @type {?boolean} */ - oi?: boolean; + oi?: number | boolean; }; /** diff --git a/lib/connect.ts b/lib/connect.ts index 399477d..9d48f0e 100644 --- a/lib/connect.ts +++ b/lib/connect.ts @@ -5,7 +5,7 @@ import csvParse from 'papaparse'; import sha256 from 'crypto-js/sha256'; import qs from 'qs'; import utils from './utils'; -import { KiteConnectParams, Varieties, GTTStatusTypes, AnyObject, Order, MarginOrder, VirtualContractParam, TransactionTypes, KiteConnectInterface, CancelOrderParams, ExitOrderParams, ModifyGTTParams, ModifyOrderParams, PlaceGTTParams, PlaceMFOrderParams, PlaceOrderParams, ConvertPositionParams, Exchanges } from '../interfaces'; +import { KiteConnectParams, Varieties, GTTStatusTypes, AnyObject, Order, MarginOrder, VirtualContractParam, TransactionTypes, KiteConnectInterface, CancelOrderParams, ExitOrderParams, ModifyGTTParams, ModifyOrderParams, PlaceGTTParams, PlaceMFOrderParams, PlaceOrderParams, ConvertPositionParams, Exchanges, GetHistoricalDataParams } from '../interfaces'; import { DEFAULTS, ROUTES } from '../constants'; @@ -697,7 +697,12 @@ export class KiteConnect implements KiteConnectInterface { * @param {(number | boolean)} [oi=false] * @returns {Promise} */ - getHistoricalData(instrument_token: number | string, interval: string, from_date: string | Date, to_date: string | Date, continuous: number | boolean = false, oi: number | boolean = false) { + getHistoricalData(instrument_token: GetHistoricalDataParams['instrument_token'], + interval: GetHistoricalDataParams['interval'], + from_date: GetHistoricalDataParams['from_date'], + to_date: GetHistoricalDataParams['to_date'], + continuous: GetHistoricalDataParams['continuous'] = false, + oi: GetHistoricalDataParams['oi'] = false) { continuous = continuous ? 1 : 0; oi = oi ? 1 : 0; if (typeof to_date === 'object') to_date = _getDateTimeString(to_date)