Skip to content

Commit 1c10040

Browse files
committed
docs: record resolved executor lifecycle finding
1 parent 45ad7db commit 1c10040

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

‎audits/2026-08-trailofbits-pr60/response.md‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ Response branch: `feat/permission-hook-module-type`
1515
| TOB-KERNEL-8 | Shared scoped-hook deinitialization | Low | **Acknowledged** |
1616
| TOB-KERNEL-9 | In-flight scoped-hook removal | Medium | **Acknowledged** |
1717
| TOB-KERNEL-10 | Unchecked initData decoding | Medium | **Fixed** — `d92c9a2` |
18-
| TOB-KERNEL-11 | Ignored executor callback failures | Medium | **Acknowledged** (documented in code) |
18+
| TOB-KERNEL-11 | Ignored executor callback failures | Medium | **Fixed** — `e491d02`; accepted in fix review |
1919
| TOB-KERNEL-12 | Missing executor installation check | Medium | **Fixed** — `bac0d4b` |
2020
| TOB-KERNEL-13 | Unbound userOpHash in executeUserOp | Low | **Fixed** — `b42fa9a` |
2121

2222
Every fix ships with a regression test named for its window (`test/unit/`): `Erc1271AccountBinding`,
2323
`ExecutorRevocation`, `PolicyRootUninstall`, `WrongTypeUninstall`, `SetRootTeardownOrder`,
24-
`InstallDataBounds`, `ExecuteUserOpBinding`.
24+
`InstallDataBounds`, `ExecuteUserOpBinding`, `ExecutorReinstallation`.
2525

2626
## Fix notes
2727

@@ -36,6 +36,10 @@ Every fix ships with a regression test named for its window (`test/unit/`): `Erc
3636
signers. Root policy changes require an explicit root rotation.
3737
- **TOB-10** — `installModule`/`uninstallModule` route through `_decodeModuleData`, which requires
3838
both dynamic fields of `InstallModuleDataFormat` to lie entirely within the declared `initData`.
39+
- **TOB-11** — executor installation requires a successful low-level `onInstall` call before
40+
granting authority (`e491d02`). Plain EOAs remain supported; failed `onUninstall` cleanup cannot
41+
block removal. Reinstallation with a failing callback cannot reactivate stale authorization.
42+
The reviewer accepted this fix and confirmed that the finding would be marked resolved.
3943
- **TOB-12** — `_uninstallExecutor` requires `installed`; same-class checks added to
4044
`_uninstallValidator` (installed) and `_uninstallSelector` (module must match the selector's
4145
target). New error: `ModuleNotInstalled`.
@@ -80,9 +84,3 @@ Every fix ships with a regression test named for its window (`test/unit/`): `Erc
8084
fully-authorized operation. Hook-author requirement (documented): scoped hooks MUST reject
8185
protected calls that target the account itself unless they specifically intend to allow
8286
self-administration.
83-
- **TOB-11 (executor install ignores onInstall)** — intentional, now documented at the site
84-
(`ExecutorManager._installExecutor`): executors may be EOAs or contracts that do not implement
85-
`IModule`, so lifecycle callbacks are best-effort for this module type. The exploitable half of
86-
the reported chain is closed by `ded1250` (revocation is unconditional); the remaining
87-
trade-off — reinstalling a stateful executor whose `onInstall` reverts re-activates its previous
88-
state — is accepted and placed on the installer.

0 commit comments

Comments
 (0)