From 8f7e196a0a4c9b7ab5dc8fbb3d0dc7286ea8fa88 Mon Sep 17 00:00:00 2001 From: Albert Jimenez Date: Wed, 28 May 2014 15:42:02 -0700 Subject: [PATCH 1/2] Pass exception error object into results When trying to fix a failing test, it is extremely important to know the call stack of any occurring exceptions; just knowing the error message is usually not enough to pin point the problem, so it would be useful also have access to the exception itself. --- src/test/js/TestRunner.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/js/TestRunner.js b/src/test/js/TestRunner.js index 8356e3e0509..dfe563be97b 100644 --- a/src/test/js/TestRunner.js +++ b/src/test/js/TestRunner.js @@ -708,6 +708,7 @@ node.parent.results[testName] = { result: failed ? "fail" : "pass", message: error ? error.getMessage() : "Test passed", + error: error, type: "test", name: testName, duration: duration From 1849c71f05f0346235023207dc5322ab63034b6a Mon Sep 17 00:00:00 2001 From: Albert Jimenez Date: Wed, 28 May 2014 16:25:01 -0700 Subject: [PATCH 2/2] Print exception stack --- src/test/js/YTestWrapAfter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/js/YTestWrapAfter.js b/src/test/js/YTestWrapAfter.js index 9d36dddd492..2c2cdea4b9a 100644 --- a/src/test/js/YTestWrapAfter.js +++ b/src/test/js/YTestWrapAfter.js @@ -99,7 +99,7 @@ if (!YUI.YUITest) { break; case this.TEST_FAIL_EVENT: - message = event.testName + ": failed.\n" + event.error.getMessage(); + message = event.testName + ": failed.\n" + event.error.stack; messageType = "fail"; break;