Clean up unused Docker orchestration functions after Docker Compose migration

[coderabbitai]

Description

After the migration to Docker Compose orchestration in PR #1178, several functions in components/clp-package-utils/clp_package_utils/general.py are no longer used and should be removed.

Confirmed Unused Functions

The following functions/classes have no callers outside their definition in general.py:

1. get_celery_connection_env_vars_list()
2. get_common_env_vars_list()
3. get_credential_env_vars_list()
4. CLPDockerMounts class

Additional Functions to Investigate

The following functions may also be unused but need verification:

• is_container_running()
• is_container_exited()
• DockerMount class
• DockerMountType enum
• append_docker_port_settings_for_host_ips()

These were heavily used in the old start_clp.py but are likely obsolete now that Docker Compose handles orchestration.

Related

• PR feat(deployment)!: Migrate package orchestration to Docker Compose (resolves #1177); Temporarily remove support for multi-node deployments. #1178: Docker Compose migration
• Comment: feat(deployment)!: Migrate package orchestration to Docker Compose (resolves #1177); Temporarily remove support for multi-node deployments. #1178 (comment)
• Requested by: @junhaoliao

[junhaoliao]

also

clp/components/clp-package-utils/clp_package_utils/controller.py

Line 60 in 6bf138f

LOG_FILE_ACCESS_MODE = stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRP | stat.S_IROTH

is unused