Fix lint errors

Author: revolter

lib/xcode/install.rb

@@ -465,24 +465,24 @@ def prereleases
     end
 
     def compare_versions(first, second)
-        # Sort by version number
-        numeric_comparation = first.to_f <=> second.to_f
-        return numeric_comparation if numeric_comparation != 0
-
-        # Return beta versions before others
-        is_first_beta = first.include?('beta')
-        is_second_beta = second.include?('beta')
-        return -1 if is_first_beta && !is_second_beta
-        return 1 if !is_first_beta && is_second_beta
-
-        # Return GM versions before others
-        is_first_gm = first.include?('GM')
-        is_second_gm = second.include?('GM')
-        return -1 if is_first_gm && !is_second_gm
-        return 1 if !is_first_gm && is_second_gm
-
-        # Sort alphabetically
-        return first <=> second
+      # Sort by version number
+      numeric_comparation = first.to_f <=> second.to_f
+      return numeric_comparation if numeric_comparation != 0
+
+      # Return beta versions before others
+      is_first_beta = first.include?('beta')
+      is_second_beta = second.include?('beta')
+      return -1 if is_first_beta && !is_second_beta
+      return 1 if !is_first_beta && is_second_beta
+
+      # Return GM versions before others
+      is_first_gm = first.include?('GM')
+      is_second_gm = second.include?('GM')
+      return -1 if is_first_gm && !is_second_gm
+      return 1 if !is_first_gm && is_second_gm
+
+      # Sort alphabetically
+      first <=> second
     end
 
     def hdiutil(*args)

spec/list_spec.rb

@@ -47,9 +47,19 @@ def fake_installed_xcodes(*names)
       end
 
       it 'lists all versions in the correct order' do
-        fake_xcodes '12 beta 4', '12 beta 3', '12 beta 2', '12 for macOS Universal Apps beta 2', '12 beta', '12 for macOS Universal Apps beta', '12.0.1', '12', '12 beta 6', '12 beta 5', '12.1 GM seed', '12.2 beta 3', '12.2 beta', '12.2 beta 2'
+        fake_xcodes(
+          '12 beta 4', '12 beta 3', '12 beta 2', '12 for macOS Universal Apps beta 2',
+          '12 beta', '12 for macOS Universal Apps beta', '12.0.1', '12', '12 beta 6',
+          '12 beta 5', '12.1 GM seed', '12.2 beta 3', '12.2 beta', '12.2 beta 2'
+        )
         fake_installed_xcodes
-        installer.list.should == "12 beta\n12 beta 2\n12 beta 3\n12 beta 4\n12 beta 5\n12 beta 6\n12 for macOS Universal Apps beta\n12 for macOS Universal Apps beta 2\n12\n12.0.1\n12.1 GM seed\n12.2 beta\n12.2 beta 2\n12.2 beta 3"
+
+        versions = [
+          '12 beta', '12 beta 2', '12 beta 3', '12 beta 4', '12 beta 5', '12 beta 6',
+          '12 for macOS Universal Apps beta', '12 for macOS Universal Apps beta 2',
+          '12', '12.0.1', '12.1 GM seed', '12.2 beta', '12.2 beta 2', '12.2 beta 3'
+        ]
+        installer.list.split("\n").should == versions
       end
     end