Recognize CMA as a valid center in rd_grib2.F#285
Conversation
jimbresch
changed the title
|
This small change recognizes CMA as a valid center for labeling purposes. It was already added to g2print, but for some reason was omitted from rd_grib2.F. It can be merged once the unnecessary comment is removed.
|
|
Thanks for adding that. |
Do you mean the |
|
Yes, we don't normally include 'edited by' or 'modified by' comments in the code. The pull request serves as the attribution. |
| map%source = 'UKMO' | ||
| else if (icenter .eq. 78 .or. icenter .eq. 79 ) then | ||
| map%source = 'DWD' | ||
| else if (icenter .eq. 38) then ! Edited by Geek-007 |
There was a problem hiding this comment.
@Geek-007 Could you please remove the comment ! Edited by Geek-007? As @jimbresch notes, the git commit will record your changes:
Author: Geek <1069xxxxxx@qq.com>
Date: Tue Apr 14 12:26:02 2026 +0800
Add support for CMA source in rd_grib2.F
and anyone running, e.g., git show 4ec99405 will be able to see exactly what changes you have contributed in the commit. (Note, I anonymized your email address above, though it will appear correctly in the commit info.)
It would also be preferable for your changes to come in from a branch other than master. We typically only merge the master branch to the develop branch after a release, and so merging your master branch to our develop branch does create a less than ideal commit history. If you'd like some pointers on committing your changes to a new branch, just let me know and I will be glad to help.
4 participants
Include support for CMA dataset.