fix(karma): add and use karma.labels helper (fixes #843)#844
Open
tolleiv wants to merge 1 commit into
Open
Conversation
Member
|
Thanks! Unfortunately we don't install the GA CRDs (here), would you mind enabling them? |
Author
|
@desaintmartin sure I'll take care of integrating them |
tolleiv
force-pushed
the
fix-843
branch
2 times, most recently
from
d66a339 to
d240d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing karma.labels helper, extends the tests to actually test the httpRoute feature and use the karma.labels and karma.selectorLabels in all resources of the chart.
I left out the configmap - this uses labels which are not consistent within the chart, therefore these wer unchanged.