Skip to content

Commit 2d887bf

Browse files
ci: drop the ui-test step that checks the installed nodeps.js size
The step guarded against a test dependency that replaces the wheel under test, as once happened in ipyvue. In this repo CI installs the PR wheel by path, and the run for 2331216 shows that nothing replaced it. If an older ipyvuetify did replace it, overlay_css_test.py already fails, because the old nodeps.js makes those buttons uppercase. So the step adds nothing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent 2331216 commit 2d887bf

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

‎.github/workflows/test.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,6 @@ jobs:
121121
name: ipyvuetify-dist-${{ github.run_number }}
122122
- name: Install ipyvuetify
123123
run: python -m pip install "$(find dist -name '*.whl')[test]"
124-
- name: Check that the UI tests use this build
125-
# a test dependency that pins another ipyvuetify would replace this wheel
126-
run: |
127-
f="$(python -c 'import sys; print(sys.prefix)')/share/jupyter/nbextensions/jupyter-vuetify/nodeps.js"
128-
ls -l "$f"
129-
test "$(wc -c < "$f")" -le 250000
130124
- name: Install chromium
131125
run: playwright install chromium
132126
- name: Run ui-tests

0 commit comments

Comments
 (0)