Skip to content

Commit a71f4de

Browse files
committed
fix: address review feedback
1 parent 42ac2f2 commit a71f4de

13 files changed

Lines changed: 17 additions & 58 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,4 @@ docsite/
4343
.superpowers
4444
docs/superpowers
4545
.claude
46+
.idea/

.idea/.gitignore

Lines changed: 0 additions & 10 deletions
This file was deleted.

.idea/inspectionProfiles/Project_Default.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/misc.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/modules.xml

Lines changed: 0 additions & 8 deletions
This file was deleted.

.idea/prettier.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/vcs.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/waveterm.iml

Lines changed: 0 additions & 9 deletions
This file was deleted.

frontend/app/view/preview/preview-directory.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ function TableBody({
435435
}
436436
ContextMenuModel.getInstance().showContextMenu(menu, e);
437437
},
438-
[canCreateEntries, setRefreshVersion, conn]
438+
[canCreateEntries, conn, setErrorMsg]
439439
);
440440

441441
const allRows = table.getRowModel().flatRows;
@@ -878,7 +878,7 @@ function DirectoryPreview({ model }: DirectoryPreviewProps) {
878878

879879
ContextMenuModel.getInstance().showContextMenu(menu, e);
880880
},
881-
[canCreateEntries, setRefreshVersion, conn, newFile, newDirectory, dirPath]
881+
[canCreateEntries, conn, newFile, newDirectory, dirPath, finfo]
882882
);
883883

884884
return (

frontend/app/view/term/termutil.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@ import { describe, expect, it } from "vitest";
33
import { getWheelLineDelta } from "./termutil";
44

55
describe("getWheelLineDelta", () => {
6+
it("returns 0 for zero and non-finite deltas", () => {
7+
expect(getWheelLineDelta(0, 0, 16, 40)).toBe(0);
8+
expect(getWheelLineDelta(Number.NaN, 0, 16, 40)).toBe(0);
9+
expect(getWheelLineDelta(Number.POSITIVE_INFINITY, 0, 16, 40)).toBe(0);
10+
expect(getWheelLineDelta(Number.NEGATIVE_INFINITY, 0, 16, 40)).toBe(0);
11+
});
12+
613
it("converts pixel deltas using cell height", () => {
714
expect(getWheelLineDelta(32, 0, 16, 40)).toBe(2);
815
expect(getWheelLineDelta(-24, 0, 12, 40)).toBe(-2);

0 commit comments

Comments
 (0)