Merge pull request #247 from cincodenada/bugfix/numeric_keys

Numeric keys break array inspection

Author: BlackIkeEagle

plugin/python/vdebug/dbgp.py

@@ -669,8 +669,12 @@ def _determine_displayname(self,node):
             if self.language == 'php' or \
                     self.language == 'perl':
                 if self.parent.type == 'array':
-                    self.display_name = self.parent.display_name + \
-                        "['%s']" % node.get('name')
+                    if node.get('name').isdigit():
+                        self.display_name = self.parent.display_name + \
+                            "[%s]" % node.get('name')
+                    else:
+                        self.display_name = self.parent.display_name + \
+                            "['%s']" % node.get('name')
                 else:
                     self.display_name = self.parent.display_name + \
                         "->"+node.get('name')

tests/test_dbgp_eval_property.py

@@ -0,0 +1,42 @@
+if __name__ == "__main__":
+    import sys
+    sys.path.append('../plugin/python/')
+import unittest2 as unittest
+import vdebug.dbgp
+import xml.etree.ElementTree as ET
+
+class EvalPropertyTest(unittest.TestCase):
+    def __get_eval_property(self,xml_string,code,lang):
+        xml = ET.fromstring(xml_string)
+        firstnode = xml[0]
+        return vdebug.dbgp.EvalProperty(firstnode,code,lang)
+
+    def test_numeric_keys(self):
+        prop = self.__get_eval_property(\
+            """<?xml version="1.0" encoding="iso-8859-1"?>
+<response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="eval" transaction_id="13">
+    <property 
+      address="140722906708544" type="array"
+      children="1" numchildren="2" page="0" pagesize="32">
+        <property
+          name="0" address="140022315302704"
+          type="array" children="1" numchildren="1"></property>
+        <property 
+          name="key" address="140022315307008"
+          type="array" children="1" numchildren="1"></property>
+    </property>
+</response>
+""", '$testarr', 'php')
+
+        self.assertEqual(prop.display_name,'$testarr')
+        self.assertEqual(prop.value,'')
+        self.assertEqual(prop.type,'array')
+        self.assertEqual(prop.depth,0)
+        self.assertTrue(prop.has_children)
+        self.assertEqual(prop.child_count(),2)
+
+        self.assertEqual(prop.children[0].type,'array')
+        self.assertEqual(prop.children[0].display_name,'$testarr[0]')
+
+        self.assertEqual(prop.children[1].type,'array')
+        self.assertEqual(prop.children[1].display_name,"$testarr['key']")