RSDK-13909: Update CLI machine shell for windows#6030
Open
allisonschiang wants to merge 4 commits into
Open
Conversation
The setRaw helper in startRobotPartShell shelled out to stty to put
the local terminal into raw mode for an interactive remote shell. stty
isn't available on Windows, so `viam machine part shell` failed with
"exec: stty: executable file not found in %PATH%".
Replace exec.Command("stty", ...) with term.MakeRaw / term.Restore from
golang.org/x/term, which is already a dependency (used by cli/auth.go)
and handles both POSIX termios and the Windows console API natively.
…ix-shell-stty-windows
…ix-shell-stty-windows
viambot
added
the
safe to test
viambot
added
safe to test
allisonschiang
commented
May 20, 2026
| return rawMode.Run() | ||
| } | ||
| if err := setRaw(true); err != nil { | ||
| stdinFd := int(os.Stdin.Fd()) |
Member
Author
There was a problem hiding this comment.
stty doesn't work on windows - this alternative does
allisonschiang
commented
May 20, 2026
| for { | ||
| resp, err := client.Recv() | ||
| if err != nil { | ||
| errMsg := "" |
Member
Author
There was a problem hiding this comment.
error msg would not propogate when trying to connect to windows and it would just silently fail, so I added this here so our "windows isn't supported" error we already have is visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, viam machines part shell doesn't work on windows because the implementation uses stty, which doesn't work on windows. I am adding a new implementation that should work on all OSs
Testing:
Windows -> mac works
Windows -> linux works
mac -> linux works
mac -> windows doesn't work (as expected) but updated it to warn instead of silently failing
linux -> mac works