Bump yaml-cpp to v0.8.0

[elazarg]

yaml-cpp release 0.8.0 is not yaml-cpp-0.8.0: https://github.com/jbeder/yaml-cpp/tags. The support for CMake3.4 does not play well with our configuration, so

• Use -DCMAKE_POLICY_VERSION_MINIMUM=3.14
• Statically link yaml-cpp: target_compile_definitions(ebpfverifier PRIVATE YAML_CPP_STATIC_DEFINE)

There's a pending PR regarding removal of CMake 3.4:
jbeder/yaml-cpp#1351

[coderabbitai]

Walkthrough

This pull request updates the CMakeLists.txt file to change the GIT_TAG for the yaml-cpp external project from "yaml-cpp-0.7.0" to "0.8.0". It also sets the minimum CMake policy version to 3.14 and removes outdated comments regarding MSVC compiler handling of the C++ standard, while keeping the overall structure of the ExternalProject_Add function intact.

Changes

File(s)	Change Summary
CMakeLists.txt	Updated GIT_TAG for yaml-cpp from "yaml-cpp-0.7.0" to "0.8.0"; set minimum CMake policy version to 3.14; removed comments on MSVC compiler handling; added YAML_CPP_STATIC_DEFINE for ebpfverifier target.

Possibly related PRs

• fix: include for yaml-cpp #722: The changes in the main PR focus on upgrading the yaml-cpp library version and modifying CMake policies, while the retrieved PR addresses variable renaming and inclusion adjustments for the same library, indicating a direct relationship in their handling of yaml-cpp.
• Move all yaml related code into test #750: The changes in the main PR, which involve updating the yaml-cpp version and adding a compile definition, are related to the modifications in the retrieved PR that conditionally handle the inclusion of the yaml-cpp package in the CMake configuration. Both PRs involve updates to the CMakeLists.txt file concerning the yaml-cpp library.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afee971 and afa1eda.

📒 Files selected for processing (1)

• CMakeLists.txt (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: build_windows (Release, library)
• GitHub Check: build_ubuntu (Release, library)
• GitHub Check: build_windows (Debug, tests)
• GitHub Check: build_windows (Debug, library)
• GitHub Check: build_windows (Release, tests)
• GitHub Check: build_ubuntu (Release, tests)
• GitHub Check: build_ubuntu (Debug, tests)
• GitHub Check: build_ubuntu (Debug)
• GitHub Check: build_ubuntu (Release)
• GitHub Check: Analyze (cpp)

🔇 Additional comments (3)

CMakeLists.txt (3)

73-74: Update yaml-cpp ExternalProject GIT_TAG to "0.8.0".
The GIT_TAG has been updated from the previous version (likely "yaml-cpp-0.7.0") to "0.8.0". Verify that the tag naming convention matches the repository (i.e. check if it should be prefixed with "yaml-cpp-") to ensure consistency with the git tags.

---

79-79: Enforce minimum CMake policy explicitly.
The addition of the -DCMAKE_POLICY_VERSION_MINIMUM=3.14 argument forces an explicit policy version for the external project. Given that the overall project requires CMake 3.16, double-check that setting the policy to 3.14 here is intentional for compatibility reasons with yaml-cpp.

---

134-134: Add compile definition for static yaml-cpp linking.
The new compile definition YAML_CPP_STATIC_DEFINE added to the ebpfverifier target ensures that yaml-cpp is linked as a static library. Confirm that this configuration aligns with the overall linking strategy and does not conflict with other dependencies.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 88.177%. remained the same
when pulling afa1eda on bump-yamlcpp-0.8.0
into 632c125 on main.

[elazarg]

@Alan-Jowett is this a good solution?

[Alan-Jowett]

@Alan-Jowett is this a good solution?

Looks good to me.