From 449bc49f96fbe896c5e448f44c68e7fa91a88180 Mon Sep 17 00:00:00 2001
From: ethanglaser <ethan.glaser@intel.com>
Date: Fri, 20 Mar 2026 14:25:52 -0700
Subject: [PATCH] Remove || true from tests

---
 .github/workflows/ci-aarch64.yml    | 8 ++++----
 dev/bazel/tests/mkl_linkage_test.sh | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci-aarch64.yml b/.github/workflows/ci-aarch64.yml
index 7128844eee5..e4e93deda9c 100644
--- a/.github/workflows/ci-aarch64.yml
+++ b/.github/workflows/ci-aarch64.yml
@@ -108,14 +108,14 @@ jobs:
         run: |
           echo "::warning::This step is designed to always pass, please look for more details"
           # timeout added due to hanging enable_thread_pinning example, and should be removed when fixed
-          timeout 12m .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface daal/cpp --build-system cmake --backend ref || true
+          timeout 12m .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface daal/cpp --build-system cmake --backend ref
         env:
           CMAKE_GENERATOR: Ninja
 
       - name: oneapi/cpp examples
         run: |
           echo "::warning::This step is designed to always pass, please look for more details"
-          .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface oneapi/cpp --build-system cmake --backend ref || true
+          .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface oneapi/cpp --build-system cmake --backend ref
         env:
           CMAKE_GENERATOR: Ninja
 
@@ -185,7 +185,7 @@ jobs:
         run: |
           echo "::warning::This step is designed to always pass, please check logs for more details"
           # timeout added due to hanging enable_thread_pinning example, and should be removed when fixed
-          timeout 12m .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface daal/cpp --build-system cmake --backend ref --rng-backend openrng || true
+          timeout 12m .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface daal/cpp --build-system cmake --backend ref --rng-backend openrng
         env:
           CMAKE_GENERATOR: Ninja
 
@@ -193,7 +193,7 @@ jobs:
         run: |
           echo "::warning::This step is designed to always pass, please check logs for more details"
           # excludes examples from EXCLUDE_LIST present in examples/daal/cpp/CMakeLists.txt
-          .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface oneapi/cpp --build-system cmake --backend ref --rng-backend openrng || true
+          .ci/scripts/test.sh --test-kind examples --build-dir __release_lnx_${{ matrix.os.cxx }} --compiler ${{ matrix.os.cxx }} --interface oneapi/cpp --build-system cmake --backend ref --rng-backend openrng
         env:
           CMAKE_GENERATOR: Ninja
 
diff --git a/dev/bazel/tests/mkl_linkage_test.sh b/dev/bazel/tests/mkl_linkage_test.sh
index cb2f908e304..227448cbf8b 100755
--- a/dev/bazel/tests/mkl_linkage_test.sh
+++ b/dev/bazel/tests/mkl_linkage_test.sh
@@ -56,11 +56,11 @@ fi
 # Static lib must NOT contain MKL archive object files
 # (libmkl_core.a, libmkl_intel_ilp64.a, libmkl_tbb_thread.a objects)
 AR_CONTENTS=$(ar t "$STATIC_LIB") || { echo "ERROR: ar failed on $STATIC_LIB"; exit 1; }
-MKL_ARCHIVE_OBJS=$(echo "$AR_CONTENTS" | grep -c '^_mkl_\|^mkl_blas\|^mkl_vml\|^libmkl' || true)
+MKL_ARCHIVE_OBJS=$(echo "$AR_CONTENTS" | grep -c '^_mkl_\|^mkl_blas\|^mkl_vml\|^libmkl)
 check "Static lib: no MKL archive objects merged in" "$MKL_ARCHIVE_OBJS"
 
 # Static lib must NOT have defined MKL symbols (only undefined refs are ok)
-MKL_DEFINED=$(nm "$STATIC_LIB" 2>/dev/null | grep -c ' [Tt] mkl_' || true)
+MKL_DEFINED=$(nm "$STATIC_LIB" 2>/dev/null | grep -c ' [Tt] mkl_')
 check "Static lib: no defined MKL symbols (U refs are ok)" "$MKL_DEFINED"
 
 echo ""
@@ -74,7 +74,7 @@ fi
 
 # Dynamic lib must NOT export MKL symbols (they must be hidden).
 # Use --defined-only to exclude undefined (U) imports — only defined exports matter.
-MKL_EXPORTED=$(nm -D --defined-only "$DYNAMIC_LIB" 2>/dev/null | grep -c ' mkl_' || true)
+MKL_EXPORTED=$(nm -D --defined-only "$DYNAMIC_LIB" 2>/dev/null | grep -c ' mkl_')
 check "Dynamic lib: no exported MKL symbols (symbols hidden via --exclude-libs)" "$MKL_EXPORTED"
 
 echo ""