WIP Libsch1 20 maintenance and security#1210
Open
Janell-Huyck wants to merge 8 commits into
Open
Conversation
Document Yarn 4/Corepack, FITS, and ImageMagick setup and troubleshooting, and make Hyrax file characterization honor SCHOLAR_FITS_PATH for reliable local uploads.
Capture the updated Ruby gem lockfile and Yarn 4 project metadata/lockfile so the repository reflects the current local dependency toolchain state.
Prevent local Yarn dependency installs from appearing as untracked files in the repository.
Avoid assigning a non-existent fits.sh path by requiring a real file match, and prune obsolete ignored advisories while adding the new ActiveStorage advisory entry.
Janell-Huyck
changed the title
Override hyrax/app.js.erb to unwrap ES module default exports before constructor calls (e.g. PermissionsControl), preventing startup errors that left batch actions and modals non-interactive. Remove duplicate jquery_ujs require from application.js manifest.
Yarn regenerates install-state.gz locally; committing it caused noisy diffs. Remove the tracked file and add it to .gitignore.
Blacklight.activate runs each onLoad callback sequentially. When Hyrax.initialize threw (wrong ES module default for collections_utils, FileManager on pages without #sortable, or CollectionTypes before the empty-wrapper check), hyrax/collections.js never registered delete-modal handlers and select-work initialization could be skipped. - Override collections_v2.es6 and collection_types.es6 to unwrap collections_utils default export and skip CollectionTypes work when .collection-types-wrapper is absent. - Guard fileManager, adminSetEditor, and collectionEditor in app.js.erb when required DOM is missing. - Fix collection type delete confirm AJAX to use jqXHR .done (gem used a non-standard done: option that jQuery ignores).
Blacklight.activate runs registered callbacks sequentially without error isolation. An uncaught exception in Hyrax.initialize prevented later scripts (including hyrax/tabs.js) from running, leaving Bootstrap work form tabs inactive so Capybara saw DOI content as non-visible. Wrap the full initialize body in try/catch and isolate FileManager construction so partial markup or affix errors cannot abort the rest of the activation chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdfor:corepack enable,corepack prepare ...)yarn installstepSCHOLAR_FITS_PATHlocal env configurationimagemagick@6) requirement and troubleshooting guidanceconfig/initializers/hyrax.rb:SCHOLAR_FITS_PATHwhen providedfits.shpath.bundler-audit.yml:CVE-2026-33658/GHSA-p9fm-f462-ggrg)package.json,yarn.lock,.yarnrc.yml,.yarn/install-state.gz) and ignoresnode_modules/in.gitignore.Gemfile.lockdependency resolution.Why
fits.sheven when unavailable, causing runtime upload failures.Notes
.bundler-audit.yml.