get macos setup/doctor to work

Author: mhfs

lib/mise_doctor.sh

@@ -24,9 +24,10 @@ fi
 fmt_header "Ruby (via mise)"
 
 if cmd_exists mise; then
-  if mise which ruby > /dev/null 2>&1; then
+  ruby_path="$(mise which ruby 2>/dev/null)"
+  if [[ -n "$ruby_path" && -x "$ruby_path" ]]; then
     check_pass "Ruby is available via mise"
-    ruby_version="$(mise exec -- ruby --version 2>&1)"
+    ruby_version="$("$ruby_path" --version 2>&1)"
     if [[ "$ruby_version" == *"ruby"* ]]; then
       check_pass "Ruby executes and reports version: $ruby_version"
     else
@@ -46,9 +47,10 @@ fi
 fmt_header "Node.js (via mise)"
 
 if cmd_exists mise; then
-  if mise which node > /dev/null 2>&1; then
+  node_path="$(mise which node 2>/dev/null)"
+  if [[ -n "$node_path" && -x "$node_path" ]]; then
     check_pass "Node.js is available via mise"
-    node_version="$(mise exec -- node --version 2>&1)"
+    node_version="$("$node_path" --version 2>&1)"
     if [[ "$node_version" == v* ]]; then
       check_pass "Node.js executes and reports version: $node_version"
     else

migrations/1771533093_cleanup_legacy_bundler_credentials.sh

@@ -0,0 +1,41 @@
+#!/bin/bash
+#
+# Clean up legacy full-URL bundler credential keys.
+#
+# Older setups (or manual configuration) stored GitHub Packages credentials
+# using the full-URL format:
+#   BUNDLE_HTTPS://RUBYGEMS__PKG__GITHUB__COM/TRUSTED/
+#
+# setup.sh now uses the host-only format (rubygems.pkg.github.com), which is
+# broader in scope and matches Bundler's documented convention. Both formats
+# work, but having the legacy key lingering causes inconsistency across
+# machines and confuses doctor.sh checks.
+#
+# This migration removes legacy full-URL keys. The correct host-only keys
+# are set by registries_setup.sh, which runs before migrations.
+
+BUNDLE_CONFIG="$HOME/.bundle/config"
+
+if [ ! -f "$BUNDLE_CONFIG" ]; then
+  echo "  No ~/.bundle/config found — nothing to clean up."
+  exit 0
+fi
+
+# Remove legacy full-URL GitHub Packages credential
+if grep -q 'BUNDLE_HTTPS://RUBYGEMS__PKG__GITHUB__COM' "$BUNDLE_CONFIG" 2>/dev/null; then
+  bundle config unset --global "https://rubygems.pkg.github.com/trusted/" > /dev/null 2>&1
+  echo "  Removed legacy key: https://rubygems.pkg.github.com/trusted/"
+else
+  echo "  No legacy GitHub Packages key found — skipping."
+fi
+
+# Remove stray BUNDLE_GET entry (likely a misconfigured credential)
+if grep -q '^BUNDLE_GET:' "$BUNDLE_CONFIG" 2>/dev/null; then
+  # bundle config doesn't support unsetting arbitrary keys cleanly,
+  # so we remove the line directly.
+  sed -i.bak '/^BUNDLE_GET:/d' "$BUNDLE_CONFIG"
+  rm -f "${BUNDLE_CONFIG}.bak"
+  echo "  Removed stray BUNDLE_GET entry."
+else
+  echo "  No stray BUNDLE_GET entry — skipping."
+fi