Removal of Star Trek Voyager: Elite Force Single-player

[thecybermind]

While adding support for GetGameAPI engines, I included STVOYSP.

After running it, it would crash at odd locations. Not before vmMain, or after entering the mod's export->Init function as I expected. But when calling syscall(G_PRINT). It was actually calling a syscall in the engine, rather than jumping to STVOYSP_syscall in game_stvoysp.cpp.

As it turns out, the single player mod is compiled with both the cgame and game code in the same DLL. The cgame system uses dllEntry/vmMain and the game system uses GetGameAPI. As a result, both entry points of QMM were being called, and it was getting increasingly difficult in having custom code JUST for STVOYSP to handle dllEntry being called first, passing the cgame syscall directly to the mod's dllEntry, then also passing all cgame vmMain calls through (but NOT the game calls routed through the export struct) without handling them.

The mod loading order had to change drastically, which basically ended up having a separate call flow just for STVOYSP.

I ended up removing support entirely, as I'm not sure it would have really gotten any use even if I got it working anyway.

[thecybermind]

I tried again to re-order the initialization in GetGameAPI games so that the mod could be loaded before returning from GetGameAPI() but it still ended up failing, so there is clearly some other interaction that would need fixing.

Also, Jedi Academy and Jedi Knight II single players function the same, so no plans to add support for them either.

[thecybermind]

Jedi Knight 2 and Jedi Academy should both be working. GetGameAPI initialization happens as normal, then dllEntry is called. Since the mod hasn't been loaded yet (Init hasn't been called), QMM stores the syscall and gives it to the mod in the vmMain handler. A flag has been added in the QMM_EXPORT macro that when set, lets vmMain know that the call came from the GetGameAPI game system as normal. If the flag ISN'T set (and the stored syscall is not null), then it means this call should be routed to the mod's vmMain().

[thecybermind]

After doing more work on Q2R and MOHAA, I believe I figured out what was causing issues with STVOYSP support. I will attempt to re-implement the code and see if I can get it to work.

[thecybermind]

After all the work to debug JASP gameplay, STVOYSP support was added easily with just a simple, standard game_stvoysp.cpp file.