From 6ca2cc0cf5a1d74455debf8c462a17a65ca976fd Mon Sep 17 00:00:00 2001
From: DavertMik <davert@testomat.io>
Date: Mon, 13 Jul 2026 05:09:13 +0300
Subject: [PATCH] refactor: style-rule cleanup in isolated files (plan 016,
 partial)

Only the items in files untouched by the other open refactor PRs, so this
does not conflict with them:
- fisherman-tools: `value === null || value === undefined` -> `value == null`
  (0/''/false are valid field values, so not `!value`)
- quartermaster: move the 4 interfaces to end of file; outputPath('a11y')
  instead of join(getOutputDir(), 'a11y'); drop the existsSync guard
  (mkdirSync recursive tolerates existing) and inline ensureDirectory away.

The bulk of plan 016 (private-method reordering, type-moves, ternary and
conditional-spread cleanups across tester/tools/provider/pilot/etc.) is
DEFERRED: 016 is the run-last plan and pure-move reorderings conflict with
every open PR. It should run after #85-#93 land.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 src/ai/fisherman-tools.ts |  2 +-
 src/ai/quartermaster.ts   | 75 ++++++++++++++++++---------------------
 2 files changed, 35 insertions(+), 42 deletions(-)

diff --git a/src/ai/fisherman-tools.ts b/src/ai/fisherman-tools.ts
index 1ade5ff..e90dedc 100644
--- a/src/ai/fisherman-tools.ts
+++ b/src/ai/fisherman-tools.ts
@@ -158,7 +158,7 @@ function extractKeyFields(body: any, result: Record<string, any> = {}, depth = 0
   }
 
   for (const [key, value] of Object.entries(body)) {
-    if (value === null || value === undefined) continue;
+    if (value == null) continue;
     if (typeof value === 'object') {
       extractKeyFields(value, result, depth + 1);
       continue;
diff --git a/src/ai/quartermaster.ts b/src/ai/quartermaster.ts
index 8c23ac2..d5c0f50 100644
--- a/src/ai/quartermaster.ts
+++ b/src/ai/quartermaster.ts
@@ -1,8 +1,8 @@
-import { existsSync, mkdirSync, writeFileSync } from 'node:fs';
+import { mkdirSync, writeFileSync } from 'node:fs';
 import { join } from 'node:path';
 import { z } from 'zod';
 import type { ActionResult } from '../action-result.ts';
-import { ConfigParser } from '../config.ts';
+import { outputPath } from '../config.ts';
 import type { StateManager, StateTransition, WebPageState } from '../state-manager.ts';
 import type { Task } from '../test-plan.ts';
 import { createDebug, tag } from '../utils/logger.ts';
@@ -12,36 +12,6 @@ import type { Provider } from './provider.ts';
 
 const debugLog = createDebug('explorbot:quartermaster');
 
-interface AxeViolation {
-  id: string;
-  impact: 'critical' | 'serious' | 'moderate' | 'minor';
-  description: string;
-  helpUrl: string;
-  nodes: Array<{ html: string; target: string[] }>;
-}
-
-interface PageAnalysis {
-  url: string;
-  stateHash: string;
-  timestamp: string;
-  axeViolations: AxeViolation[];
-}
-
-interface SemanticIssue {
-  type: 'unclear_intention' | 'confusing_naming' | 'hard_to_interact';
-  element: string;
-  issue: string;
-  suggestion: string;
-}
-
-interface AnalysisReport {
-  scenario: string;
-  timestamp: string;
-  url: string;
-  axeViolations: AxeViolation[];
-  semanticIssues: SemanticIssue[];
-}
-
 export class Quartermaster {
   private provider: Provider;
   private model?: any;
@@ -55,13 +25,12 @@ export class Quartermaster {
     this.provider = provider;
     this.model = options?.model;
 
-    const configParser = ConfigParser.getInstance();
-    this.outputDir = join(configParser.getOutputDir(), 'a11y');
+    this.outputDir = outputPath('a11y');
   }
 
   start(playwrightHelper: any, stateManager: StateManager): void {
     this.playwrightHelper = playwrightHelper;
-    this.ensureDirectory();
+    mkdirSync(this.outputDir, { recursive: true });
 
     this.unsubscribe = stateManager.onStateChange((event) => {
       this.onPageChange(event);
@@ -78,12 +47,6 @@ export class Quartermaster {
     debugLog('Quartermaster stopped');
   }
 
-  private ensureDirectory(): void {
-    if (!existsSync(this.outputDir)) {
-      mkdirSync(this.outputDir, { recursive: true });
-    }
-  }
-
   private onPageChange(event: StateTransition): void {
     const state = event.toState;
     if (!state?.hash) return;
@@ -284,3 +247,33 @@ Focus on what would confuse a real user or caused the agent to make mistakes.`;
     return content;
   }
 }
+
+interface AxeViolation {
+  id: string;
+  impact: 'critical' | 'serious' | 'moderate' | 'minor';
+  description: string;
+  helpUrl: string;
+  nodes: Array<{ html: string; target: string[] }>;
+}
+
+interface PageAnalysis {
+  url: string;
+  stateHash: string;
+  timestamp: string;
+  axeViolations: AxeViolation[];
+}
+
+interface SemanticIssue {
+  type: 'unclear_intention' | 'confusing_naming' | 'hard_to_interact';
+  element: string;
+  issue: string;
+  suggestion: string;
+}
+
+interface AnalysisReport {
+  scenario: string;
+  timestamp: string;
+  url: string;
+  axeViolations: AxeViolation[];
+  semanticIssues: SemanticIssue[];
+}