feat(view): Enable mouse cursor movement in shell

Author: ankitkrshah30

terminal-view/src/main/java/com/termux/view/TerminalView.java

@@ -611,11 +611,12 @@ public boolean onTouchEvent(MotionEvent event) {
             updateFloatingToolbarVisibility(event);
             mGestureRecognizer.onTouchEvent(event);
             return true;
-        } else if (event.isFromSource(InputDevice.SOURCE_MOUSE)) {
-            if (event.isButtonPressed(MotionEvent.BUTTON_SECONDARY)) {
+            // vvv THIS IS THE CORRECTED LINE vvv
+        } else if (event.isFromSource(InputDevice.SOURCE_MOUSE) || event.isFromSource(InputDevice.SOURCE_TOUCHSCREEN)) {
+            if (event.isFromSource(InputDevice.SOURCE_MOUSE) && event.isButtonPressed(MotionEvent.BUTTON_SECONDARY)) {
                 if (action == MotionEvent.ACTION_DOWN) showContextMenu();
                 return true;
-            } else if (event.isButtonPressed(MotionEvent.BUTTON_TERTIARY)) {
+            } else if (event.isFromSource(InputDevice.SOURCE_MOUSE) && event.isButtonPressed(MotionEvent.BUTTON_TERTIARY)) {
                 ClipboardManager clipboardManager = (ClipboardManager) getContext().getSystemService(Context.CLIPBOARD_SERVICE);
                 ClipData clipData = clipboardManager.getPrimaryClip();
                 if (clipData != null) {
@@ -636,6 +637,55 @@ public boolean onTouchEvent(MotionEvent event) {
                         break;
                 }
             }
+            else { // Mouse tracking is OFF, handle for the shell
+                if (event.getAction() == MotionEvent.ACTION_DOWN) {
+                    // --- FINAL 1D LOGIC ---
+                    // Get target row and column from the click
+                    int[] targetCoords = getColumnAndRow(event, false);
+                    int targetColumn = targetCoords[0];
+                    int targetRow = targetCoords[1];
+
+                    // vvv NEW, MORE ROBUST BOUNDARY CHECK vvv
+                    try {
+                        // Use the getSelectedText method to check the character at the clicked position.
+                        String clickedChar = mEmulator.getScreen().getSelectedText(targetColumn, targetRow, targetColumn + 1, targetRow).toString();
+
+                        // If the character at the clicked spot is empty or just a space, do nothing.
+                        if (clickedChar == null || clickedChar.trim().isEmpty()) {
+                            return true;
+                        }
+                    } catch (Exception e) {
+                        // If there's any error getting the text, it's safer to do nothing.
+                        return true;
+                    }
+                    // ^^^ END OF NEW BOUNDARY CHECK ^^^
+
+                    // Get cursor's current visual position
+                    int currentRow = mEmulator.getCursorRow();
+                    int currentColumn = mEmulator.getCursorCol();
+
+                    // Get the width of the terminal in characters
+                    int terminalWidth = mEmulator.mColumns;
+
+                    // Calculate the 1D index for both the click position and the cursor position.
+                    // This treats the multi-line input as a single long line of text.
+                    int targetIndex = (targetRow * terminalWidth) + targetColumn;
+                    int currentIndex = (currentRow * terminalWidth) + currentColumn;
+
+                    int diff = targetIndex - currentIndex;
+
+                    // --- Now, only send Left or Right commands ---
+                    if (diff > 0) { // Need to move right
+                        for (int i = 0; i < diff; i++) {
+                            handleKeyCode(android.view.KeyEvent.KEYCODE_DPAD_RIGHT, 0);
+                        }
+                    } else if (diff < 0) { // Need to move left
+                        for (int i = 0; i < -diff; i++) {
+                            handleKeyCode(android.view.KeyEvent.KEYCODE_DPAD_LEFT, 0);
+                        }
+                    }
+                }
+            }
         }
 
         mGestureRecognizer.onTouchEvent(event);