diff --git a/src/lib/components/search-attribute-filter/filter-bar.svelte b/src/lib/components/search-attribute-filter/filter-bar.svelte index 58a219142b..f1ca23e8f5 100644 --- a/src/lib/components/search-attribute-filter/filter-bar.svelte +++ b/src/lib/components/search-attribute-filter/filter-bar.svelte @@ -28,7 +28,7 @@ options, searchAttributes, id, - statusAttribute, + statusAttribute = 'ExecutionStatus', onManualSearch, includeNullConditions, }: Props = $props(); diff --git a/src/lib/components/standalone-activities/activities-summary-filter-bar/filter-bar.svelte b/src/lib/components/standalone-activities/activities-summary-filter-bar/filter-bar.svelte index 350c7c2dea..d6bfc64ed3 100644 --- a/src/lib/components/standalone-activities/activities-summary-filter-bar/filter-bar.svelte +++ b/src/lib/components/standalone-activities/activities-summary-filter-bar/filter-bar.svelte @@ -17,6 +17,5 @@ options={$activitySearchAttributeOptions} searchAttributes={$activitySearchAttributes} id="activity" - statusAttribute="ExecutionStatus" {onManualSearch} /> diff --git a/src/lib/components/workflow/filter-bar/dropdown-filter-list.svelte b/src/lib/components/workflow/filter-bar/dropdown-filter-list.svelte deleted file mode 100644 index c4128ce8f7..0000000000 --- a/src/lib/components/workflow/filter-bar/dropdown-filter-list.svelte +++ /dev/null @@ -1,115 +0,0 @@ - - -{#if visibleFilters.length > 0} -
- {#each visibleFilters as workflowFilter, i (workflowFilter.id)} - {#if isStatusFilter(workflowFilter) && i === firstExecutionStatusIndex} - updateStatusFilters(i, statusFilters)} - /> - {:else if !isStatusFilter(workflowFilter) && workflowFilter.attribute} - updateFilter(i, updatedFilter)} - onRemove={() => removeFilter(i)} - /> - {/if} - {/each} - - {#if hasMoreFilters} - - {/if} -
-{/if} diff --git a/src/lib/components/workflow/filter-bar/filter.svelte b/src/lib/components/workflow/filter-bar/filter.svelte deleted file mode 100644 index 884408a140..0000000000 --- a/src/lib/components/workflow/filter-bar/filter.svelte +++ /dev/null @@ -1,69 +0,0 @@ - - - - -
- - -
diff --git a/src/lib/components/workflow/filter-bar/index.svelte b/src/lib/components/workflow/filter-bar/index.svelte index 26387a76f2..0b00c7a614 100644 --- a/src/lib/components/workflow/filter-bar/index.svelte +++ b/src/lib/components/workflow/filter-bar/index.svelte @@ -1,40 +1,21 @@ -{#snippet actionToggleButtons()} -
- -
-{/snippet} - -
-
-
- - -
- {@render actionToggleButtons()} -
- {#if viewManualQuery} - - {/if} -
+ diff --git a/src/lib/components/workflow/filter-bar/manual-query.svelte b/src/lib/components/workflow/filter-bar/manual-query.svelte deleted file mode 100644 index c68098c2b3..0000000000 --- a/src/lib/components/workflow/filter-bar/manual-query.svelte +++ /dev/null @@ -1,87 +0,0 @@ - - -
- -
diff --git a/src/lib/components/workflow/filter-bar/search-attribute-menu.svelte b/src/lib/components/workflow/filter-bar/search-attribute-menu.svelte deleted file mode 100644 index bce1021768..0000000000 --- a/src/lib/components/workflow/filter-bar/search-attribute-menu.svelte +++ /dev/null @@ -1,158 +0,0 @@ - - - - = MAX_QUERY_LENGTH} - onclick={() => (searchAttributeValue = '')} - class="text-nowrap" - size="xs" - > - Add Filter - - - { - document.getElementById('filter-search')?.focus(); - }} - > - - -
- - {#each filteredOptions as { value, label, type }} - { - handleNewQuery(value, type); - }} - disabled={value === 'ExecutionStatus' && - !!$workflowFilters.find((f) => isStatusFilter(f))} - > -
-

{label}

- {type} -
-
- {:else} - {translate('common.no-results')} - {/each} -
-
-{#if $workflowFilters.length > 0} - -{/if} diff --git a/src/lib/components/workflow/filter-bar/status-dropdown-filter-chip.svelte b/src/lib/components/workflow/filter-bar/status-dropdown-filter-chip.svelte deleted file mode 100644 index 766979dacf..0000000000 --- a/src/lib/components/workflow/filter-bar/status-dropdown-filter-chip.svelte +++ /dev/null @@ -1,123 +0,0 @@ - - - - - ExecutionStatus ={filters.map((f) => f.value).join(', ')} - - - -
-
-

Filter by Execution Status

-
- - {#each workflowStatusFilters as status (status)} - {@const checked = - localFilters.some((filter) => filter.value === status) || - (localFilters.length === 1 && - !localFilters[0].value && - status === 'All')} - handleStatusSelect(status)} - > - {#snippet leading()} - handleStatusSelect(status)} - {checked} - label={status ?? undefined} - labelHidden - /> - {/snippet} - {#if status === 'All'} - - {:else} - - {/if} - - {/each} -
-
-
diff --git a/tests/integration/saved-query-views.spec.ts b/tests/integration/saved-query-views.spec.ts index a713b52c47..30b85c063c 100644 --- a/tests/integration/saved-query-views.spec.ts +++ b/tests/integration/saved-query-views.spec.ts @@ -50,8 +50,8 @@ test.describe('Saved Query Views', () => { test('User saved queries: create new, edit view, then delete', async ({ page, }) => { - await page.locator('#search-attribute-filter-button').click(); - await page.locator('#filter-search').fill('WorkflowId'); + await page.locator('#workflow-search-attribute-filter-button').click(); + await page.locator('#workflow-filter-search').fill('WorkflowId'); await page.getByRole('menuitem', { name: 'WorkflowId Keyword' }).click(); await page .getByTestId('dropdown-filter-chip-WorkflowId-0-text') @@ -74,8 +74,8 @@ test.describe('Saved Query Views', () => { .toBe('`WorkflowId`="user-view-1"'); await expect(page.getByTestId('my-view')).toBeVisible(); - await page.locator('#search-attribute-filter-button').click(); - await page.locator('#filter-search').fill('TaskQueue'); + await page.locator('#workflow-search-attribute-filter-button').click(); + await page.locator('#workflow-filter-search').fill('TaskQueue'); await page.getByRole('menuitem', { name: 'TaskQueue Keyword' }).click(); await page .getByTestId('dropdown-filter-chip-TaskQueue-1-text') @@ -112,8 +112,8 @@ test.describe('Saved Query Views', () => { test('User saved queries: create new, create copied view and delete', async ({ page, }) => { - await page.locator('#search-attribute-filter-button').click(); - await page.locator('#filter-search').fill('WorkflowId'); + await page.locator('#workflow-search-attribute-filter-button').click(); + await page.locator('#workflow-filter-search').fill('WorkflowId'); await page.getByRole('menuitem', { name: 'WorkflowId Keyword' }).click(); await page .getByTestId('dropdown-filter-chip-WorkflowId-0-text') @@ -136,8 +136,8 @@ test.describe('Saved Query Views', () => { .toBe('`WorkflowId`="user-view-1"'); await expect(page.getByTestId('original-view')).toBeVisible(); - await page.locator('#search-attribute-filter-button').click(); - await page.locator('#filter-search').fill('TaskQueue'); + await page.locator('#workflow-search-attribute-filter-button').click(); + await page.locator('#workflow-filter-search').fill('TaskQueue'); await page.getByRole('menuitem', { name: 'TaskQueue Keyword' }).click(); await page .getByTestId('dropdown-filter-chip-TaskQueue-1-text') diff --git a/tests/integration/workflow-bulk-actions.spec.ts b/tests/integration/workflow-bulk-actions.spec.ts index fa76a3cff6..0f0b95b20a 100644 --- a/tests/integration/workflow-bulk-actions.spec.ts +++ b/tests/integration/workflow-bulk-actions.spec.ts @@ -40,12 +40,12 @@ test.describe('Batch and Bulk Workflow Actions', () => { test('allows running workflows to be terminated by a query', async ({ page, }) => { - await page.locator('#search-attribute-filter-button').click(); + await page.locator('#workflow-search-attribute-filter-button').click(); await page.getByTestId('toggle-manual-query').click(); await page - .getByTestId('manual-search-input') + .getByTestId('workflow-manual-search-input') .fill('ExecutionStatus="Running"'); - await page.getByTestId('manual-search-button').click(); + await page.getByTestId('workflow-manual-search-button').click(); await page.getByTestId('batch-actions-checkbox').click(); await page.click('[data-testid="select-all-workflows"]'); await page.click('[data-testid="bulk-terminate-button"]'); @@ -83,12 +83,12 @@ test.describe('Batch and Bulk Workflow Actions', () => { test('allows running workflows to be cancelled by a query', async ({ page, }) => { - await page.locator('#search-attribute-filter-button').click(); + await page.locator('#workflow-search-attribute-filter-button').click(); await page.getByTestId('toggle-manual-query').click(); await page - .getByTestId('manual-search-input') + .getByTestId('workflow-manual-search-input') .fill('ExecutionStatus="Running"'); - await page.getByTestId('manual-search-button').click(); + await page.getByTestId('workflow-manual-search-button').click(); await page.getByTestId('batch-actions-checkbox').click(); await page.click('[data-testid="select-all-workflows"]'); await page.click('[data-testid="bulk-cancel-button"]'); diff --git a/tests/integration/workflows-search-attribute-filter.desktop.spec.ts b/tests/integration/workflows-search-attribute-filter.desktop.spec.ts index 6daf46b86c..1562dde539 100644 --- a/tests/integration/workflows-search-attribute-filter.desktop.spec.ts +++ b/tests/integration/workflows-search-attribute-filter.desktop.spec.ts @@ -37,10 +37,10 @@ test('it should update the datetime filter based on the selected timezone', asyn await page.getByTestId('toggle-manual-query').click(); await page - .getByTestId('manual-search-input') + .getByTestId('workflow-manual-search-input') .fill('`CloseTime`>="2025-12-25T12:00:00.000Z"'); - await page.getByTestId('manual-search-button').click(); + await page.getByTestId('workflow-manual-search-button').click(); await expect .poll(() => getQueryParam(page.url())) @@ -54,7 +54,9 @@ test('it should update the datetime filter based on the selected timezone', asyn await page.getByTestId('toggle-manual-query').click(); - let query = await page.getByTestId('manual-search-input').inputValue(); + let query = await page + .getByTestId('workflow-manual-search-input') + .inputValue(); expect(getDatetime(query)).toMatch(validDatetime); await page.getByTestId('timezones-menu-button').click(); @@ -72,7 +74,7 @@ test('it should update the datetime filter based on the selected timezone', asyn await page.getByTestId('toggle-manual-query').click(); - query = await page.getByTestId('manual-search-input').inputValue(); + query = await page.getByTestId('workflow-manual-search-input').inputValue(); expect(getDatetime(query)).toMatch(validDatetime); }); diff --git a/tests/integration/workflows-search-attribute-filter.mobile.spec.ts b/tests/integration/workflows-search-attribute-filter.mobile.spec.ts index 984e5580c1..7336c7dc57 100644 --- a/tests/integration/workflows-search-attribute-filter.mobile.spec.ts +++ b/tests/integration/workflows-search-attribute-filter.mobile.spec.ts @@ -51,10 +51,10 @@ test('it should update the datetime filter based on the selected timezone', asyn await page.getByTestId('toggle-manual-query').click(); await page - .getByTestId('manual-search-input') + .getByTestId('workflow-manual-search-input') .fill('`CloseTime`>="2025-12-25T12:00:00.000Z"'); - await page.getByTestId('manual-search-button').click(); + await page.getByTestId('workflow-manual-search-button').click(); await expect .poll(() => getQueryParam(page.url())) @@ -65,7 +65,9 @@ test('it should update the datetime filter based on the selected timezone', asyn name: 'CloseTime >= 12/25/25, 6:00:00.00 AM CST', }), ).toBeVisible(); - let query = await page.getByTestId('manual-search-input').inputValue(); + let query = await page + .getByTestId('workflow-manual-search-input') + .inputValue(); expect(getDatetime(query)).toMatch(validDatetime); await page.getByTestId('nav-profile-button').click(); @@ -86,7 +88,7 @@ test('it should update the datetime filter based on the selected timezone', asyn await page.getByTestId('nav-profile-button').click(); - query = await page.getByTestId('manual-search-input').inputValue(); + query = await page.getByTestId('workflow-manual-search-input').inputValue(); expect(getDatetime(query)).toMatch(validDatetime); });