Skip to content

Refactor PAC-96 image override option #181

Description

@pathmissing

PAC-96 introduced a new option which allows overriding already existing images. In order to stay backwards compabile, new methods and attributes were made private in
src/Subjects/FileUploadTrait.php. These should be either public or protected.

Additionally, a new constant OVERRIDE_IMAGES should be introduced in the ConfigurationKeys utility class for components using the new option:

  • techdivision/import-attribute
    • src/Subjects/OptionSubject.php
    • src/Utils/ConfigurationKeys.php
  • techdivision/import-category
    • src/Subjects/BunchSubject.php
    • src/Utils/ConfigurationKeys.php
  • techdivision/import-product
    • src/Subjects/BunchSubject.php
    • src/Utils/ConfigurationKeys.php

The necessary changes are highligted as "TODOs" in the corresponding files.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactoringThings that have to be refactored

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions