Merge pull request #8 from systemetric/delete-fix

fix(daemon): correctly handle endpoint deletion

Author: OldUser101

daemon/daemon_endpoint.cpp

@@ -55,6 +55,8 @@ void HopperDaemon::delete_endpoint(uint32_t id) {
 
     std::cout << "DELETE " << *(m_endpoints[id]) << std::endl;
 
+    inotify_rm_watch(m_inotify_fd, m_endpoints[id]->watch_fd());
+
     delete m_endpoints[id];
     m_endpoints.erase(id);
 }

daemon/daemon_inotify.cpp

@@ -55,7 +55,7 @@ void HopperDaemon::handle_endpoint_inotify(struct inotify_event *ev,
         p /= ev->name;
 
         PipeType pipe_type = detect_pipe_type(p);
-        if (pipe_type == PipeType::NONE && std::filesystem::is_directory(p)) {
+        if (pipe_type == PipeType::NONE && ev->mask & IN_ISDIR) {
             // nested endpoint
             if (create_endpoint(p) == 0)
                 std::cerr << "Endpoint creation failed! Out of IDs?"
@@ -78,13 +78,19 @@ void HopperDaemon::handle_endpoint_inotify(struct inotify_event *ev,
         std::filesystem::path p = endpoint->path();
         p /= ev->name;
 
-        HopperPipe *pipe = endpoint->pipe_by_path(p);
+        if (ev->mask & IN_ISDIR) {
+            // nested endpoint
+            delete_endpoint(p);
+        } else {
+            // pipe
+            HopperPipe *pipe = endpoint->pipe_by_path(p);
 
-        if (pipe != nullptr) {
-            if (pipe->status() == PipeStatus::ACTIVE)
-                remove_pipe(endpoint, pipe->id());
+            if (pipe != nullptr) {
+                if (pipe->status() == PipeStatus::ACTIVE)
+                    remove_pipe(endpoint, pipe->id());
 
-            endpoint->remove_by_id(pipe->id());
+                endpoint->remove_by_id(pipe->id());
+            }
         }
     }
 }
@@ -106,6 +112,11 @@ void HopperDaemon::handle_inotify() {
             continue;
         }
 
+        if (iev->mask & IN_IGNORED) {
+            // the endpoint probably got deleted, ignore
+            continue;
+        }
+
         HopperEndpoint *endpoint = endpoint_by_watch(iev->wd);
         if (endpoint == nullptr) {
             std::cout << "No endpoint found for watch ID " << iev->wd
@@ -114,10 +125,6 @@ void HopperDaemon::handle_inotify() {
         }
 
         handle_endpoint_inotify(iev, endpoint);
-
-        // The endpoint is now closed
-        if (iev->mask & IN_IGNORED)
-            delete_endpoint(endpoint->id());
     }
 }