You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit afb2921
Browse filesBrowse the repository at this point in the historyBrowse files
Let the sanitizers see pool allocations, and their reports
Two things kept this run from reporting what it is for.
ngx_palloc and ngx_pnalloc hand out slices of a pool block that the
allocator sees as one piece, so a write past an allocation lands inside
memory ASan handed over whole and no report is made. nginx keeps a
switch for exactly this case and sends every allocation straight to
malloc when NGX_DEBUG_PALLOC is set.
And the reports were being lost. nginx redirects its own stderr onto the
error log file as soon as error_log names one, which Test::Nginx always
does, so a grep over the suite's output saw ASan only indirectly --
through the worker dying -- and missed every UBSan report outright:
halt_on_error keeps the process alive, and "runtime error:" carries none
of the levels Test::Nginx looks for. With log_path the reports land in
files of their own, and the findings step reads both sources.
The options are comma separated with log_path in the middle, because
Test::Nginx appends the name of each test block to it and cuts the value
out with /log_path=([^,]+)/: a colon after the path is read as part of
it, and the option behind it ends up inside the file name, which ASan
refuses outright.
0 commit comments