diff --git a/pkg/cmd/plugin/install.go b/pkg/cmd/plugin/install.go index 8060d0932..beda283bf 100644 --- a/pkg/cmd/plugin/install.go +++ b/pkg/cmd/plugin/install.go @@ -65,13 +65,13 @@ func parseInstallArg(arg string) (string, string) { return plugin, version } -func (ic *InstallCmd) installPluginByName(cmd *cobra.Command, arg string) error { +func (ic *InstallCmd) installPluginByName(cmd *cobra.Command, arg string) (version string, err error) { pluginName, version := parseInstallArg(arg) plugin, err := plugins.LookUpPlugin(cmd.Context(), ic.cfg, ic.fs, pluginName) if err != nil { - return err + return version, err } if len(version) == 0 { @@ -86,7 +86,7 @@ func (ic *InstallCmd) installPluginByName(cmd *cobra.Command, arg string) error err = plugin.Install(ctx, ic.cfg, ic.fs, version, ic.apiBaseURL) - return err + return version, err } func (ic *InstallCmd) runInstallCmd(cmd *cobra.Command, args []string) error { @@ -95,6 +95,7 @@ func (ic *InstallCmd) runInstallCmd(cmd *cobra.Command, args []string) error { } var err error + var version string color := ansi.Color(os.Stdout) // Refresh the plugin before proceeding @@ -103,12 +104,15 @@ func (ic *InstallCmd) runInstallCmd(cmd *cobra.Command, args []string) error { return err } - err = ic.installPluginByName(cmd, args[0]) + version, err = ic.installPluginByName(cmd, args[0]) if err != nil { return err } - fmt.Println(color.Green("✔ installation complete.")) + if err == nil { + successMsg := fmt.Sprintf("✔ installation of v%s complete.", version) + fmt.Println(color.Green(successMsg)) + } return nil } diff --git a/pkg/plugins/RUNTIME.md b/pkg/plugins/RUNTIME.md index ba5223273..4be7b4492 100644 --- a/pkg/plugins/RUNTIME.md +++ b/pkg/plugins/RUNTIME.md @@ -34,7 +34,7 @@ When a user installs a plugin with runtime requirements: $ stripe plugin install generate downloading Node.js v20.18.1 runtime... installing 'generate' v1.0.0... -✔ installation complete. +✔ installation of 1.0.0 complete. ``` The runtime is: