Skip to content

wip: add Windows unmanaged pre-prod acceptance coverage#6721

Draft
snyk-will wants to merge 5 commits into
mainfrom
test/unmanaged-preprod-windows-acceptance
Draft

wip: add Windows unmanaged pre-prod acceptance coverage#6721
snyk-will wants to merge 5 commits into
mainfrom
test/unmanaged-preprod-windows-acceptance

Conversation

@snyk-will
Copy link
Copy Markdown
Contributor

@snyk-will snyk-will commented Apr 10, 2026 •
edited
Loading

No description provided.

@snyk-will
test: add Windows unmanaged pre-prod acceptance coverage
5434935 
Add a dedicated unmanaged acceptance suite and CircleCI job that pins the Windows run to the pre-prod unmanaged environment. This lets the CLI team rerun the Windows path against unmanaged-lookup before rolling the migration forward again.

Made-with: Cursor
@snyk-will snyk-will requested review from a team as code owners April 10, 2026 12:36
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 10, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-will snyk-will marked this pull request as draft April 10, 2026 12:38
@snyk-will snyk-will changed the title test: add Windows unmanaged pre-prod acceptance coverage wip: add Windows unmanaged pre-prod acceptance coverage Apr 10, 2026
@snyk-pr-review-bot
Copy link
Copy Markdown

snyk-pr-review-bot Bot commented Apr 10, 2026

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Shell Incompatibility 🟠 [major]

The default value for the new test_command parameter (line 1592) uses Unix shell syntax $(expr ...) which is incompatible with the Windows executor (win-server2022-amd64) used by acceptance tests. While the new pre-prod job overrides this, any future or existing Windows acceptance test that relies on the default test_command will fail to execute the shard calculation. The existing shard_calc_cmd parameter (line 1598) already addresses this for sharding, but moving the logic into a string-interpolated default for test_command bypasses that abstraction for the shell.

 
test_command:
  type: string
  default: npm run test:acceptance -- --selectProjects coreCli --shard=<< parameters.shard_calc_cmd >>/<< parameters.shards >>
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 1.00)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Fails
🚫

"wip: add Windows unmanaged pre-prod acceptance coverage" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
🚫

"extend test" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
🚫

"wip: fix tests" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
🚫

"wip: add back + new test" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
🚫

"remove unused steps" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
Warnings
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 2ae4137

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions Bot added the Stale label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

⚠️ DO NOT MERGE ⚠️ Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@snyk-will