Skip to content

Commit d10383f

Browse files
committed
REST filter with Observation API
1 parent 71f5aa4 commit d10383f

37 files changed

Lines changed: 2056 additions & 527 deletions

File tree

implementation/observation-otel-bridge/src/main/java/io/smallrye/opentelemetry/instrumentation/observation/cdi/ObservationExtension.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,18 @@
2020
import jakarta.enterprise.inject.spi.Extension;
2121
import jakarta.enterprise.util.Nonbinding;
2222

23-
import io.micrometer.observation.ObservationRegistry;
2423
import io.micrometer.observation.annotation.Observed;
24+
import io.smallrye.opentelemetry.instrumentation.observation.ObservationRegistryProducer;
25+
import io.smallrye.opentelemetry.instrumentation.observation.handler.OpenTelemetryObservationHandler;
2526

2627
public class ObservationExtension implements Extension {
2728
public void beforeBeanDiscovery(@Observes BeforeBeanDiscovery beforeBeanDiscovery, BeanManager beanManager) {
2829
beforeBeanDiscovery.addInterceptorBinding(
2930
new ObservedAnnotatedType(beanManager.createAnnotatedType(Observed.class)));
3031

31-
beforeBeanDiscovery.addAnnotatedType(ObservationRegistry.class, ObservationRegistry.class.getName());
32+
beforeBeanDiscovery.addAnnotatedType(OpenTelemetryObservationHandler.class,
33+
OpenTelemetryObservationHandler.class.getName());
34+
beforeBeanDiscovery.addAnnotatedType(ObservationRegistryProducer.class, ObservationRegistryProducer.class.getName());
3235
}
3336

3437
public void afterBeanDiscovery(@Observes AfterBeanDiscovery afterBeanDiscovery, BeanManager beanManager) {

implementation/observation-otel-bridge/src/main/java/io/smallrye/opentelemetry/instrumentation/observation/cdi/ObservedInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
import io.micrometer.observation.ObservationRegistry;
99
import io.micrometer.observation.annotation.Observed;
10-
import io.smallrye.opentelemetry.instrumentation.observation.cdi.convention.DefaultObservedInterceptorConvention;
1110
import io.smallrye.opentelemetry.instrumentation.observation.cdi.convention.CdiInterceptorContext;
11+
import io.smallrye.opentelemetry.instrumentation.observation.cdi.convention.DefaultObservedInterceptorConvention;
1212
import io.smallrye.opentelemetry.instrumentation.observation.cdi.convention.ObservedInterceptorConvention;
1313
import io.smallrye.opentelemetry.instrumentation.observation.cdi.convention.ObservedInterceptorDocumentation;
1414

implementation/observation-otel-bridge/src/test/java/io/smallrye/opentelemetry/implementation/observation/ObservationOTelTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,15 @@
3838
import io.smallrye.opentelemetry.implementation.cdi.OpenTelemetryExtension;
3939
import io.smallrye.opentelemetry.implementation.config.OpenTelemetryConfigProducer;
4040
import io.smallrye.opentelemetry.implementation.micrometer.cdi.MicrometerExtension;
41-
import io.smallrye.opentelemetry.instrumentation.observation.ObservationRegistryProducer;
4241
import io.smallrye.opentelemetry.instrumentation.observation.cdi.ObservationExtension;
43-
import io.smallrye.opentelemetry.instrumentation.observation.handler.OpenTelemetryObservationHandler;
4442
import io.smallrye.opentelemetry.test.InMemoryMetricExporter;
4543
import io.smallrye.opentelemetry.test.InMemoryMetricExporterProvider;
4644
import io.smallrye.opentelemetry.test.InMemorySpanExporter;
4745
import io.smallrye.opentelemetry.test.InMemorySpanExporterProvider;
4846

4947
@EnableAutoWeld
5048
@AddExtensions({ OpenTelemetryExtension.class, ConfigExtension.class, ObservationExtension.class, MicrometerExtension.class })
51-
@AddBeanClasses({ OpenTelemetryConfigProducer.class, ObservationRegistryProducer.class, OpenTelemetryObservationHandler.class,
52-
InMemoryMetricExporter.class, InMemoryMetricExporterProvider.class,
49+
@AddBeanClasses({ OpenTelemetryConfigProducer.class, InMemoryMetricExporter.class, InMemoryMetricExporterProvider.class,
5350
InMemorySpanExporter.class, InMemorySpanExporterProvider.class, })
5451
class ObservationOTelTest {
5552
@Inject

implementation/rest-observation/pom.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
<groupId>io.smallrye.opentelemetry</groupId>
1717
<artifactId>smallrye-opentelemetry-api</artifactId>
1818
</dependency>
19-
19+
<dependency>
20+
<groupId>io.smallrye.opentelemetry</groupId>
21+
<artifactId>smallrye-opentelemetry-micrometer-otel-bridge</artifactId>
22+
</dependency>
2023
<dependency>
2124
<groupId>io.smallrye.opentelemetry</groupId>
2225
<artifactId>smallrye-opentelemetry-observation-otel-bridge</artifactId>

implementation/rest-observation/src/main/java/io/smallrye/opentelemetry/implementation/rest.observation/ObservationClientFilter.java

Lines changed: 0 additions & 190 deletions
This file was deleted.

0 commit comments

Comments
 (0)