Conversation
5 tasks
Contributor
Author
|
@marcprux pinging you for a code review (not urgent, but I think this may have fallen through the cracks) |
tifroz
force-pushed
the
experimental_animation-performance
branch
from
August 22, 2026 20:35
45b9111 to
3af2f36
Compare
- preserve ForEach and stack composition identity - improve equatable content caching and bridge equality - support explicit first-render animation sources - prevent animation provenance from leaking between modifiers - document Android rendering performance APIs
- verify state updates refresh content without replacing the native host - verify parent size changes remeasure the same host - verify environment values remain available and update inside the boundary - document that fixed sizing belongs outside the boundary
tifroz
force-pushed
the
experimental_animation-performance
branch
from
September 16, 2026 03:11
3af2f36 to
96118ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift testCodex generated the code with supervision, UI tests conducted manually to validate performance improvements
Summary
Add Android rendering controls for expensive view subtrees, including the bridge support used by SkipFuseUI #134.
androidEquatablereuses evaluated content while its equality value remains unchanged.androidCompositionBoundaryretains a Compose host and its lifecycle while its ID stays stable. Changed input revisions update content without replacing the host, and parent constraints still control measurement.ForEachchild identity in stacks, including inner-row reordering in nested loops.Testing
After rebasing onto upstream/main, all 46 Android JUnit tests passed under Robolectric:
AndroidEquatableTests: equality reuse, collection changes, lazy stacks, environment values, hoisted state, actions, and bridged factories.AndroidCompositionBoundaryTests: retained hosting, input updates, inherited environment, and remeasurement.AnimationTestsand 18TransactionTests: animation behavior and provenance.RenderingRegressionTests: animation isolation, content-sized hosting, and nested row identity inHStack,VStack, andZStack.skip test --filter RenderingRegressionTests --filter AnimationTests \ --filter TransactionTests --filter AndroidEquatableTests \ --filter AndroidCompositionBoundaryTestsThe Swift build and test harness also completed successfully. The parity summary reports 41 matched cases; the five Kotlin-only regression tests are recorded separately in the JUnit reports.
git diff --checkpassed.Usage Example
For an
Equatableview whose equality covers all body inputs:For a view that is not itself
Equatable, supply an explicit key. Keep changing actions outside the cached subtree:Here
contactmust beEquatableand contain every value used byContactLabel's body. Include any additional body-affecting inputs in a combined key.For independently retained hosting:
API Shape
The bridge surface also adds lazy
AndroidEquatableContentandAndroidCompositionBoundaryprojection lifecycle support.Risks / Limitations
inputsfor parent-driven content changes. Changingidreplaces the host and its retained state.compositorTransformchanges rendered pixels without changing layout position.Notes
SkipFuseUI #134 depends on this PR.