Adopt SSP coding-style

Author: tvdijen

src/Controller/MetaRefresh.php

@@ -57,6 +57,7 @@ public function setAuthUtils(Utils\Auth $authUtils): void
         $this->authUtils = $authUtils;
     }
 
+
     /**
      * Inject the \SimpleSAML\Configuration dependency.
      *
@@ -67,6 +68,7 @@ public function setModuleConfig(Configuration $module_config): void
         $this->module_config = $module_config;
     }
 
+
     /**
      * @return \SimpleSAML\XHTML\Template
      */

src/MetaLoader.php

@@ -371,6 +371,7 @@ private function containsArray($src, $dst): bool
         }
     }
 
+
     /**
      * Create HTTP context, with any available caches taken into account
      *
@@ -402,6 +403,7 @@ private function createContext(array $source): array
         return ['http' => ['header' => $rawheader]];
     }
 
+
     private function addCachedMetadata(array $source): void
     {
         if (!isset($this->oldMetadataSrc)) {

src/MetaRefresh.php

@@ -21,16 +21,18 @@ class MetaRefresh
      */
     private Configuration $modconfig;
 
+
     /**
-     * @param \SimpleSAML\Configuration              $config The configuration to use by the module.
-     * @param \SimpleSAML\Configuration              $modconfig The module-specific configuration to use by the module.
+     * @param \SimpleSAML\Configuration $config The configuration to use by the module.
+     * @param \SimpleSAML\Configuration $modconfig The module-specific configuration to use by the module.
      */
     public function __construct(Configuration $config, Configuration $modconfig)
     {
         $this->config = $config;
         $this->modconfig = $modconfig;
     }
 
+
     /**
      * @param string|null $crontag Only refresh sets which allow this crontag
      */

tests/src/MetaLoaderTest.php

@@ -74,6 +74,7 @@ final class MetaLoaderTest extends TestCase
         'tags' => ['my-tag'],
     ];
 
+
     protected function setUp(): void
     {
         $this->config = Configuration::loadFromArray(
@@ -87,6 +88,7 @@ protected function setUp(): void
         $this->source['src'] = dirname(__FILE__, 2) . '/testmetadata.xml';
     }
 
+
     protected function tearDown(): void
     {
         if ($this->tmpdir && is_dir($this->tmpdir)) {
@@ -97,6 +99,7 @@ protected function tearDown(): void
         }
     }
 
+
     public function testMetaLoader(): void
     {
         $this->metaloader->loadSource($this->source);
@@ -121,6 +124,7 @@ public function testMetaLoader(): void
         );
     }
 
+
     public function testSignatureVerificationCertificatePass(): void
     {
         $this->metaloader->loadSource(
@@ -130,6 +134,7 @@ public function testSignatureVerificationCertificatePass(): void
         $this->expectOutputRegex('/UTEbMBkGA1UECgwSRXhhbXBsZSBVbml2ZXJzaXR5MRgwFgYDVQQDDA9pZHAuZXhh/');
     }
 
+
     public function testWriteMetadataFiles(): void
     {
         $this->tmpdir = tempnam(sys_get_temp_dir(), 'SSP:tests:metarefresh:');
@@ -149,6 +154,7 @@ public function testWriteMetadataFiles(): void
         );
     }
 
+
     /**
      * Tests that setting an explicit expiry time will be added to the resulting
      * metadata when the original metadata lacks one.
@@ -175,7 +181,8 @@ public function testMetaLoaderSetExpiryWhenNotPresent(): void
         $this->assertEquals(1000, $metadata['https://idp.example.com/idp/shibboleth']['expire']);
     }
 
-    /*
+
+    /**
      * Test two matching EntityAttributes (R&S + Sirtfi)
      */
     public function testAttributewhitelist1(): void
@@ -211,7 +218,8 @@ public function testAttributewhitelist1(): void
         );
     }
 
-    /*
+
+    /**
      * Test non-matching of the whitelist: result should be empty set
      */
     public function testAttributewhitelist2(): void
@@ -234,7 +242,8 @@ public function testAttributewhitelist2(): void
         $this->assertEmpty($output);
     }
 
-    /*
+
+    /**
      * Test non-matching of first entry, but matching of second, using both
      * RegistrationInfo and EntityAttributes
      */