Fix some QA issues

Author: tvdijen

psalm-dev.xml

@@ -17,13 +17,6 @@
     </projectFiles>
 
     <issueHandlers>
-        <!-- Ignore UnresolvableInclude on CLI-scripts -->
-        <UnresolvableInclude>
-            <errorLevel type="suppress">
-                <file name="tests/bootstrap.php" />
-            </errorLevel>
-        </UnresolvableInclude>
-
         <!-- Ignore MissingOverrideAttribute -->
         <MissingOverrideAttribute>
             <errorLevel type="suppress">

tests/src/ARPTest.php

@@ -8,7 +8,7 @@
 use SimpleSAML\Configuration;
 use SimpleSAML\Module\metarefresh\ARP;
 
-class ARPTest extends TestCase
+final class ARPTest extends TestCase
 {
     public function testARP(): void
     {

tests/src/Controller/MetaRefreshTest.php

@@ -14,7 +14,7 @@
  *
  * @package SimpleSAML\Test
  */
-class MetaRefreshTest extends TestCase
+final class MetaRefreshTest extends TestCase
 {
     /** @var \SimpleSAML\Configuration */
     protected $authsources;
@@ -98,9 +98,7 @@ public function testMetaRefresh()
         $c->setAuthUtils($this->authUtils);
         $c->setModuleConfig($this->module_config);
 
-        /** @var \SimpleSAML\XHTML\Template $response */
         $response = $c->main();
-
         $this->assertTrue($response->isSuccessful());
 
         $contents = $response->getContents();

tests/src/MetaLoaderTest.php

@@ -8,7 +8,7 @@
 use PHPUnit\Framework\TestCase;
 use SimpleSAML\Configuration;
 
-class MetaLoaderTest extends TestCase
+final class MetaLoaderTest extends TestCase
 {
     /** \SimpleSAML\Module\metarefresh\MetaLoader */
     private $metaloader;