Temporarily stop running PHP-linter #222
php.yml
on: push
Annotations
20 errors and 13 warnings
|
UnusedIssueHandlerSuppression:
psalm-dev.xml#L0
/home/runner/work/simplesamlphp-module-metarefresh/simplesamlphp-module-metarefresh/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "MissingOverrideAttribute" for /tests was not thrown. (see https://psalm.dev/326)
|
|
UnusedIssueHandlerSuppression:
psalm-dev.xml#L0
/home/runner/work/simplesamlphp-module-metarefresh/simplesamlphp-module-metarefresh/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
|
|
MissingOverrideAttribute:
tests/src/MetaLoaderTest.php#L89
tests/src/MetaLoaderTest.php:89:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::teardown should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/MetaLoaderTest.php#L76
tests/src/MetaLoaderTest.php:76:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::setup should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedClass:
tests/src/MetaLoaderTest.php#L11
tests/src/MetaLoaderTest.php:11:7: UnusedClass: Class SimpleSAML\Test\Module\metarefresh\MetaLoaderTest is never used (see https://psalm.dev/075)
|
|
UnnecessaryVarAnnotation:
tests/src/Controller/MetaRefreshTest.php#L101
tests/src/Controller/MetaRefreshTest.php:101:18: UnnecessaryVarAnnotation: The @var SimpleSAML\XHTML\Template annotation for $response is unnecessary (see https://psalm.dev/212)
|
|
MissingOverrideAttribute:
tests/src/Controller/MetaRefreshTest.php#L76
tests/src/Controller/MetaRefreshTest.php:76:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\metarefresh\Controller\_home_runner_work_simplesamlphp_module_metarefresh_simplesamlphp_module_metarefresh_tests_src_Controller_MetaRefreshTest_php_75_1942::requireadmin should have the "Override" attribute (see https://psalm.dev/358)
|
|
MissingOverrideAttribute:
tests/src/Controller/MetaRefreshTest.php#L35
tests/src/Controller/MetaRefreshTest.php:35:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::setup should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedClass:
tests/src/Controller/MetaRefreshTest.php#L17
tests/src/Controller/MetaRefreshTest.php:17:7: UnusedClass: Class SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest is never used (see https://psalm.dev/075)
|
|
UnusedClass:
tests/src/ARPTest.php#L11
tests/src/ARPTest.php:11:7: UnusedClass: Class SimpleSAML\Test\Module\metarefresh\ARPTest is never used (see https://psalm.dev/075)
|
|
RiskyTruthyFalsyComparison:
src/MetaLoader.php#L66
src/MetaLoader.php:66:14: RiskyTruthyFalsyComparison: Operand of type array<array-key, mixed>|null contains type array<array-key, mixed>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
|
ClassMustBeFinal:
src/MetaLoader.php#L18
src/MetaLoader.php:18:7: ClassMustBeFinal: Class SimpleSAML\Module\metarefresh\MetaLoader is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
PossiblyUnusedParam:
src/Controller/MetaRefresh.php#L69
src/Controller/MetaRefresh.php:69:51: PossiblyUnusedParam: Param #1 is never referenced in this method (see https://psalm.dev/134)
|
|
PossiblyUnusedParam:
src/Controller/MetaRefresh.php#L59
src/Controller/MetaRefresh.php:59:45: PossiblyUnusedParam: Param #1 is never referenced in this method (see https://psalm.dev/134)
|
|
PossiblyUnusedParam:
src/Controller/MetaRefresh.php#L46
src/Controller/MetaRefresh.php:46:33: PossiblyUnusedParam: Param #1 is never referenced in this method (see https://psalm.dev/134)
|
|
ParseError:
src/Controller/MetaRefresh.php#L46
src/Controller/MetaRefresh.php:46:33: ParseError: Promoted property config clashes with an existing property (see https://psalm.dev/173)
|
|
ClassMustBeFinal:
src/Controller/MetaRefresh.php#L22
src/Controller/MetaRefresh.php:22:7: ClassMustBeFinal: Class SimpleSAML\Module\metarefresh\Controller\MetaRefresh is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
RedundantCondition:
src/ARP.php#L39
src/ARP.php:39:13: RedundantCondition: Type string for $attributemap_filename is never null (see https://psalm.dev/122)
|
|
ClassMustBeFinal:
src/ARP.php#L10
src/ARP.php:10:7: ClassMustBeFinal: Class SimpleSAML\Module\metarefresh\ARP is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
UnusedVariable:
config-templates/module_metarefresh.php#L3
config-templates/module_metarefresh.php:3:1: UnusedVariable: $config is never referenced or the value is not used (see https://psalm.dev/077)
|
|
PropertyNotSetInConstructor:
tests/src/MetaLoaderTest.php#L17
tests/src/MetaLoaderTest.php:17:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
|
MissingPropertyType:
tests/src/MetaLoaderTest.php#L14
tests/src/MetaLoaderTest.php:14:13: MissingPropertyType: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$metaloader does not have a declared type - consider SimpleSAML\Module\metarefresh\MetaLoader|null (see https://psalm.dev/045)
|
|
ClassMustBeFinal:
tests/src/MetaLoaderTest.php#L11
tests/src/MetaLoaderTest.php:11:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\metarefresh\MetaLoaderTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
MissingReturnType:
tests/src/Controller/MetaRefreshTest.php#L89
tests/src/Controller/MetaRefreshTest.php:89:21: MissingReturnType: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::testMetaRefresh does not have a return type, expecting void (see https://psalm.dev/050)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L29
tests/src/Controller/MetaRefreshTest.php:29:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authUtils is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L26
tests/src/Controller/MetaRefreshTest.php:26:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L23
tests/src/Controller/MetaRefreshTest.php:23:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L20
tests/src/Controller/MetaRefreshTest.php:20:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authsources is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
ClassMustBeFinal:
tests/src/Controller/MetaRefreshTest.php#L17
tests/src/Controller/MetaRefreshTest.php:17:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
ClassMustBeFinal:
tests/src/ARPTest.php#L11
tests/src/ARPTest.php:11:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\metarefresh\ARPTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
PossiblyUnusedMethod:
src/MetaLoader.php#L495
src/MetaLoader.php:495:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\metarefresh\MetaLoader::dumpMetadataStdOut (see https://psalm.dev/087)
|
|
PossiblyUnusedMethod:
src/MetaLoader.php#L77
src/MetaLoader.php:77:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\metarefresh\MetaLoader::getTypes (see https://psalm.dev/087)
|
|
UnusedClass:
src/Controller/MetaRefresh.php#L22
src/Controller/MetaRefresh.php:22:7: UnusedClass: Class SimpleSAML\Module\metarefresh\Controller\MetaRefresh is never used (see https://psalm.dev/075)
|