fix: Use httpErrorAsException when passed as parameter to SendGridClient constructor (#1180)

When passing httpErrorAsException as a parameter to the SendGridClient constructor, it was not used for anything. This change passes the value the the options object created.

Author: mortenbock

src/SendGrid/SendGridClient.cs

@@ -20,9 +20,10 @@ public class SendGridClient : BaseClient
         /// <param name="requestHeaders">A dictionary of request headers.</param>
         /// <param name="version">API version, override AddVersion to customize.</param>
         /// <param name="urlPath">Path to endpoint (e.g. /path/to/endpoint).</param>
+        /// <param name="httpErrorAsException">Indicates whether HTTP error responses should be raised as exceptions. Default is false.</param>
         /// <returns>Interface to the Twilio SendGrid REST API.</returns>
         public SendGridClient(IWebProxy webProxy, string apiKey, string host = null, Dictionary<string, string> requestHeaders = null, string version = null, string urlPath = null, bool httpErrorAsException = false)
-            : base(webProxy, buildOptions(apiKey, host, requestHeaders, version, urlPath))
+            : base(webProxy, buildOptions(apiKey, host, requestHeaders, version, urlPath, httpErrorAsException))
         {
         }
 
@@ -35,9 +36,10 @@ public SendGridClient(IWebProxy webProxy, string apiKey, string host = null, Dic
         /// <param name="requestHeaders">A dictionary of request headers.</param>
         /// <param name="version">API version, override AddVersion to customize.</param>
         /// <param name="urlPath">Path to endpoint (e.g. /path/to/endpoint).</param>
+        /// <param name="httpErrorAsException">Indicates whether HTTP error responses should be raised as exceptions. Default is false.</param>
         /// <returns>Interface to the Twilio SendGrid REST API.</returns>
         public SendGridClient(HttpClient httpClient, string apiKey, string host = null, Dictionary<string, string> requestHeaders = null, string version = null, string urlPath = null, bool httpErrorAsException = false)
-            : base(httpClient, buildOptions(apiKey, host, requestHeaders, version, urlPath))
+            : base(httpClient, buildOptions(apiKey, host, requestHeaders, version, urlPath, httpErrorAsException))
         {
         }
 
@@ -51,7 +53,7 @@ public SendGridClient(HttpClient httpClient, string apiKey, string host = null,
         /// <param name="urlPath">Path to endpoint (e.g. /path/to/endpoint).</param>
         /// <returns>Interface to the Twilio SendGrid REST API.</returns>
         public SendGridClient(string apiKey, string host = null, Dictionary<string, string> requestHeaders = null, string version = null, string urlPath = null)
-            : base(buildOptions(apiKey, host, requestHeaders, version, urlPath))
+            : base(buildOptions(apiKey, host, requestHeaders, version, urlPath, false))
         {
         }
 
@@ -76,7 +78,7 @@ public SendGridClient(HttpClient httpClient, SendGridClientOptions options)
         {
         }
 
-        private static SendGridClientOptions buildOptions(string apiKey, string host, Dictionary<string, string> requestHeaders, string version, string urlPath)
+        private static SendGridClientOptions buildOptions(string apiKey, string host, Dictionary<string, string> requestHeaders, string version, string urlPath, bool httpErrorAsException)
         {
             return new SendGridClientOptions
             {
@@ -85,6 +87,7 @@ private static SendGridClientOptions buildOptions(string apiKey, string host, Di
                 RequestHeaders = requestHeaders ?? DefaultOptions.RequestHeaders,
                 Version = version ?? DefaultOptions.Version,
                 UrlPath = urlPath ?? DefaultOptions.UrlPath,
+                HttpErrorAsException = httpErrorAsException
             };
         }
     }

tests/SendGrid.Tests/Integration.cs

@@ -6121,7 +6121,18 @@ public async Task TestRetryBehaviourSucceedsOnSecondAttempt()
         }
 
         [Fact]
-        public async void TestHttpErrorAsException()
+        public async void TestHttpErrorAsExceptionWhenSetInOptions()
+        {
+            await TestHttpErrorAsException((client, apiKey) => new SendGridClient(client, new SendGridClientOptions {ApiKey = apiKey, HttpErrorAsException = true}));
+        }
+
+        [Fact]
+        public async void TestHttpErrorAsExceptionWhenSetAsParameter()
+        {
+            await TestHttpErrorAsException((client, apiKey) => new SendGridClient(client, apiKey, httpErrorAsException: true));
+        }
+
+        private async Task TestHttpErrorAsException(Func<HttpClient, string, SendGridClient> createClientFunc)
         {
             var responseObject = new
             {
@@ -6138,7 +6149,7 @@ public async void TestHttpErrorAsException()
             });
             var mockHandler = new FixedStatusAndMessageHttpMessageHandler(HttpStatusCode.ServiceUnavailable, responseMessage);
             var mockClient = new HttpClient(mockHandler);
-            var client = new SendGridClient(mockClient, new SendGridClientOptions { ApiKey = fixture.apiKey, HttpErrorAsException = true });
+            var client = createClientFunc(mockClient, fixture.apiKey);
 
             try
             {