fping 5.6: some code refactoring

[schweikert]

After fping 5.5 is released and after the traceroute code is merged, we could do some refactorings. I have in mind:

1. Consistent variable names for command-line options. Proposal: "opt_XXXX" (e.g. opt_count) for values and "opt_XXXX_on" (e.g. opt_count_on) for on/off switches.
2. Move option parsing to a separate file (e.g. flags.c and flags.h).
3. Move printing functions to a separate file (e.g. output.c / output.h)
4. Move stats functions (global stats) to a separate file (e.g. stats.c / stats.h)

[gsnw-sebast]

I'm starting with point 1

[gsnw-sebast]

I implemented the following in #454

• Move printing functions to a separate file (e.g. output.c / output.h)
• Move stats functions (global stats) to a separate file (e.g. stats.c / stats.h)

[gsnw-sebast]

With the change for point 1, I changed the variables to opt_xxx or opt_xxx_on.
Wouldn't it be better with point 2 to pack the options into a typedef struct?

[schweikert]

I thought about that, but it's a bigger change. For now, I would just do the renaming.

[gsnw-sebast]

I would add the following to flag.c

flag.c

typedef struct {
  int version;
  int verbose;
} Option_flags;

Option_flags options_init(void) {
  Option_flags opt = {0};
  return opt;
}

The following would then be inserted at the beginning of fping.c

fping.c

Options options_flags = options_init();

The typedef name Option_flags is just an example. I can't think of anything better right now.
After that, the variables can be changed with options_flags.verbose = 1;

If an option is to be assigned a value other than 0 beforehand, this must be adjusted in options_init() by opt.version = 1;.

What do you think about that?

[gsnw-sebast]

I've made the change in pull request #469. It doesn't need to be included in version 5.6.