Skip to content

fix: allow args when setting $EDITOR (WORKBENCH-4480) - #24

Merged
lduan11 merged 1 commit into
mainfrom
fix/editor-args
Nov 5, 2026
Merged

lduan11 merged 1 commit into
mainfrom
fix/editor-args

Conversation

@lduan11

@lduan11 lduan11 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Allow the $EDITOR env var, which selects the path of the editor to use in edit commands, to take additional args. If users would like to use vscode to edit their resource, the -w flag must be appended so the terminal waits for the temporary file to be closed, e.g. code -w <filename>.

Test by setting EDITOR='code -w'.

Code Changes

In getEditor(), now handle optional arguments.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Go test coverage by package

# Package name                                                    | Coverage
+ github.com/sassoftware/wbctl/cmd/wbctl                          | 100.00% (12/12 lines)
+ github.com/sassoftware/wbctl/internal/auth                      | 100.00% (709/709 lines)
+ github.com/sassoftware/wbctl/internal/auth0admin                | 100.00% (5/5 lines)
+ github.com/sassoftware/wbctl/internal/cmd                       | 100.00% (92/92 lines)
+ github.com/sassoftware/wbctl/internal/cmd/api                   | 100.00% (107/107 lines)
+ github.com/sassoftware/wbctl/internal/cmd/auth                  | 100.00% (29/29 lines)
+ github.com/sassoftware/wbctl/internal/cmd/cancel                | 100.00% (90/90 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create                | 100.00% (37/37 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/image          | 100.00% (208/208 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/job            | 100.00% (265/265 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/job_submission | 100.00% (130/130 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/snapshot       | 100.00% (192/192 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/workbench      | 100.00% (219/219 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/workspace      | 100.00% (335/335 lines)
+ github.com/sassoftware/wbctl/internal/cmd/delete                | 100.00% (151/151 lines)
+ github.com/sassoftware/wbctl/internal/cmd/describe              | 100.00% (240/240 lines)
+ github.com/sassoftware/wbctl/internal/cmd/edit                  | 100.00% (229/229 lines)
+ github.com/sassoftware/wbctl/internal/cmd/flags                 | 100.00% (342/342 lines)
+ github.com/sassoftware/wbctl/internal/cmd/get                   | 100.00% (310/310 lines)
+ github.com/sassoftware/wbctl/internal/cmd/log                   | 100.00% (119/119 lines)
+ github.com/sassoftware/wbctl/internal/cmd/login                 | 100.00% (51/51 lines)
+ github.com/sassoftware/wbctl/internal/cmd/logout                | 100.00% (26/26 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile               | 100.00% (14/14 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/config        | 100.00% (70/70 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/init          | 100.00% (87/87 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/list          | 100.00% (29/29 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/show          | 100.00% (62/62 lines)
+ github.com/sassoftware/wbctl/internal/cmd/rebuild               | 100.00% (86/86 lines)
+ github.com/sassoftware/wbctl/internal/cmd/settings              | 100.00% (70/70 lines)
+ github.com/sassoftware/wbctl/internal/cmd/state                 | 100.00% (113/113 lines)
+ github.com/sassoftware/wbctl/internal/cmd/version               | 100.00% (37/37 lines)
+ github.com/sassoftware/wbctl/internal/cmd/whoami                | 100.00% (67/67 lines)
+ github.com/sassoftware/wbctl/internal/configutil                | 100.00% (15/15 lines)
+ github.com/sassoftware/wbctl/internal/debugutil                 | 100.00% (5/5 lines)
+ github.com/sassoftware/wbctl/internal/httputil                  | 100.00% (30/30 lines)
+ github.com/sassoftware/wbctl/internal/i18n                      | 100.00% (31/31 lines)
+ github.com/sassoftware/wbctl/internal/jsonutil                  | 100.00% (11/11 lines)
+ github.com/sassoftware/wbctl/internal/logutil                   | 100.00% (37/37 lines)
+ github.com/sassoftware/wbctl/internal/maputil                   | 100.00% (32/32 lines)
+ github.com/sassoftware/wbctl/internal/osutil                    | 100.00% (20/20 lines)
+ github.com/sassoftware/wbctl/internal/postgrest                 | 100.00% (5/5 lines)
+ github.com/sassoftware/wbctl/internal/printutil                 | 100.00% (496/496 lines)
+ github.com/sassoftware/wbctl/internal/services/auth0admin       | 100.00% (36/36 lines)
+ github.com/sassoftware/wbctl/internal/services/workbench        | 100.00% (1552/1552 lines)
+ github.com/sassoftware/wbctl/internal/sliceutil                 | 100.00% (14/14 lines)
+ github.com/sassoftware/wbctl/internal/stubs                     | 100.00% (515/515 lines)
+ github.com/sassoftware/wbctl/internal/timeutil                  | 100.00% (8/8 lines)
+ github.com/sassoftware/wbctl/internal/types                     | 100.00% (87/87 lines)
+ github.com/sassoftware/wbctl/internal/ui                        | 100.00% (106/106 lines)
+ github.com/sassoftware/wbctl/internal/wbctljson                 | 100.00% (286/286 lines)

@lduan11
lduan11 marked this pull request as ready for review November 5, 2026 18:49
@lduan11
lduan11 merged commit 9db2e43 into main Nov 5, 2026
8 checks passed
@lduan11
lduan11 deleted the fix/editor-args branch November 5, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants