Repository navigation
fix: allow args when setting $EDITOR (WORKBENCH-4480) - #24
Merged
Merged
Conversation
|
Go test coverage by package # Package name | Coverage
+ github.com/sassoftware/wbctl/cmd/wbctl | 100.00% (12/12 lines)
+ github.com/sassoftware/wbctl/internal/auth | 100.00% (709/709 lines)
+ github.com/sassoftware/wbctl/internal/auth0admin | 100.00% (5/5 lines)
+ github.com/sassoftware/wbctl/internal/cmd | 100.00% (92/92 lines)
+ github.com/sassoftware/wbctl/internal/cmd/api | 100.00% (107/107 lines)
+ github.com/sassoftware/wbctl/internal/cmd/auth | 100.00% (29/29 lines)
+ github.com/sassoftware/wbctl/internal/cmd/cancel | 100.00% (90/90 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create | 100.00% (37/37 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/image | 100.00% (208/208 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/job | 100.00% (265/265 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/job_submission | 100.00% (130/130 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/snapshot | 100.00% (192/192 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/workbench | 100.00% (219/219 lines)
+ github.com/sassoftware/wbctl/internal/cmd/create/workspace | 100.00% (335/335 lines)
+ github.com/sassoftware/wbctl/internal/cmd/delete | 100.00% (151/151 lines)
+ github.com/sassoftware/wbctl/internal/cmd/describe | 100.00% (240/240 lines)
+ github.com/sassoftware/wbctl/internal/cmd/edit | 100.00% (229/229 lines)
+ github.com/sassoftware/wbctl/internal/cmd/flags | 100.00% (342/342 lines)
+ github.com/sassoftware/wbctl/internal/cmd/get | 100.00% (310/310 lines)
+ github.com/sassoftware/wbctl/internal/cmd/log | 100.00% (119/119 lines)
+ github.com/sassoftware/wbctl/internal/cmd/login | 100.00% (51/51 lines)
+ github.com/sassoftware/wbctl/internal/cmd/logout | 100.00% (26/26 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile | 100.00% (14/14 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/config | 100.00% (70/70 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/init | 100.00% (87/87 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/list | 100.00% (29/29 lines)
+ github.com/sassoftware/wbctl/internal/cmd/profile/show | 100.00% (62/62 lines)
+ github.com/sassoftware/wbctl/internal/cmd/rebuild | 100.00% (86/86 lines)
+ github.com/sassoftware/wbctl/internal/cmd/settings | 100.00% (70/70 lines)
+ github.com/sassoftware/wbctl/internal/cmd/state | 100.00% (113/113 lines)
+ github.com/sassoftware/wbctl/internal/cmd/version | 100.00% (37/37 lines)
+ github.com/sassoftware/wbctl/internal/cmd/whoami | 100.00% (67/67 lines)
+ github.com/sassoftware/wbctl/internal/configutil | 100.00% (15/15 lines)
+ github.com/sassoftware/wbctl/internal/debugutil | 100.00% (5/5 lines)
+ github.com/sassoftware/wbctl/internal/httputil | 100.00% (30/30 lines)
+ github.com/sassoftware/wbctl/internal/i18n | 100.00% (31/31 lines)
+ github.com/sassoftware/wbctl/internal/jsonutil | 100.00% (11/11 lines)
+ github.com/sassoftware/wbctl/internal/logutil | 100.00% (37/37 lines)
+ github.com/sassoftware/wbctl/internal/maputil | 100.00% (32/32 lines)
+ github.com/sassoftware/wbctl/internal/osutil | 100.00% (20/20 lines)
+ github.com/sassoftware/wbctl/internal/postgrest | 100.00% (5/5 lines)
+ github.com/sassoftware/wbctl/internal/printutil | 100.00% (496/496 lines)
+ github.com/sassoftware/wbctl/internal/services/auth0admin | 100.00% (36/36 lines)
+ github.com/sassoftware/wbctl/internal/services/workbench | 100.00% (1552/1552 lines)
+ github.com/sassoftware/wbctl/internal/sliceutil | 100.00% (14/14 lines)
+ github.com/sassoftware/wbctl/internal/stubs | 100.00% (515/515 lines)
+ github.com/sassoftware/wbctl/internal/timeutil | 100.00% (8/8 lines)
+ github.com/sassoftware/wbctl/internal/types | 100.00% (87/87 lines)
+ github.com/sassoftware/wbctl/internal/ui | 100.00% (106/106 lines)
+ github.com/sassoftware/wbctl/internal/wbctljson | 100.00% (286/286 lines)
|
lduan11
marked this pull request as ready for review
November 5, 2026 18:49
m-d-key
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the
$EDITORenv var, which selects the path of the editor to use ineditcommands, to take additional args. If users would like to use vscode to edit their resource, the-wflag must be appended so the terminal waits for the temporary file to be closed, e.g.code -w <filename>.Test by setting
EDITOR='code -w'.Code Changes
In
getEditor(), now handle optional arguments.