Skip to content

Commit d369927

Browse files
brnrdogbrnrdog
committed
fix!: rename makeN fns with better descriptive names
1 parent 61b1074 commit d369927

9 files changed

Lines changed: 18 additions & 30 deletions

File tree

‎src/CSSFontLoadingAPI/FontFace.res‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ external make: (~family: string, ~source: string, ~descriptors: fontFaceDescript
1111
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FontFace)
1212
*/
1313
@new
14-
external make2: (
14+
external fromDataView: (
1515
~family: string,
1616
~source: DataView.t,
1717
~descriptors: fontFaceDescriptors=?,
@@ -21,7 +21,7 @@ external make2: (
2121
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FontFace)
2222
*/
2323
@new
24-
external make3: (
24+
external fromArrayBuffer: (
2525
~family: string,
2626
~source: ArrayBuffer.t,
2727
~descriptors: fontFaceDescriptors=?,

‎src/CanvasAPI/Path2D.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ external make: (~path: path2D=?) => path2D = "Path2D"
1111
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Path2D)
1212
*/
1313
@new
14-
external make2: (~path: string=?) => path2D = "Path2D"
14+
external fromString: (~path: string=?) => path2D = "Path2D"
1515

1616
/**
1717
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/closePath)

‎src/DOMAPI/DOMMatrix.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ external make: (~init: string=?) => domMatrix = "DOMMatrix"
1111
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/DOMMatrix)
1212
*/
1313
@new
14-
external make2: (~init: array<float>=?) => domMatrix = "DOMMatrix"
14+
external fromFloatArray: (~init: array<float>=?) => domMatrix = "DOMMatrix"
1515

1616
external asDOMMatrixReadOnly: domMatrix => domMatrixReadOnly = "%identity"
1717
@scope("DOMMatrix")

‎src/DOMAPI/DOMMatrixReadOnly.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ external make: (~init: string=?) => domMatrixReadOnly = "DOMMatrixReadOnly"
1111
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/DOMMatrixReadOnly)
1212
*/
1313
@new
14-
external make2: (~init: array<float>=?) => domMatrixReadOnly = "DOMMatrixReadOnly"
14+
external fromFloatArray: (~init: array<float>=?) => domMatrixReadOnly = "DOMMatrixReadOnly"
1515

1616
@scope("DOMMatrixReadOnly")
1717
external fromMatrix: (~other: domMatrixInit=?) => domMatrixReadOnly = "fromMatrix"

‎src/DOMAPI/VideoFrame.res‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,55 +12,55 @@ external make: (~image: htmlImageElement, ~init: videoFrameInit=?) => videoFrame
1212
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
1313
*/
1414
@new
15-
external make2: (~image: svgImageElement, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
15+
external fromSvgImage: (~image: svgImageElement, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
1616

1717
/**
1818
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
1919
*/
2020
@new
21-
external make3: (~image: htmlVideoElement, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
21+
external fromVideoElement: (~image: htmlVideoElement, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
2222

2323
/**
2424
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
2525
*/
2626
@new
27-
external make4: (~image: htmlCanvasElement, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
27+
external fromCanvasElement: (~image: htmlCanvasElement, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
2828

2929
/**
3030
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
3131
*/
3232
@new
33-
external make5: (~image: imageBitmap, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
33+
external fromImageBitmap: (~image: imageBitmap, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
3434

3535
/**
3636
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
3737
*/
3838
@new
39-
external make6: (~image: offscreenCanvas, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
39+
external fromOffscreenCanvas: (~image: offscreenCanvas, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
4040

4141
/**
4242
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
4343
*/
4444
@new
45-
external make7: (~image: videoFrame, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
45+
external fromVideoFrame: (~image: videoFrame, ~init: videoFrameInit=?) => videoFrame = "VideoFrame"
4646

4747
/**
4848
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
4949
*/
5050
@new
51-
external make8: (~data: ArrayBuffer.t, ~init: videoFrameBufferInit) => videoFrame = "VideoFrame"
51+
external fromArrayBuffer: (~data: ArrayBuffer.t, ~init: videoFrameBufferInit) => videoFrame = "VideoFrame"
5252

5353
/**
5454
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
5555
*/
5656
@new
57-
external make9: (~data: sharedArrayBuffer, ~init: videoFrameBufferInit) => videoFrame = "VideoFrame"
57+
external fromSharedArrayBuffer: (~data: sharedArrayBuffer, ~init: videoFrameBufferInit) => videoFrame = "VideoFrame"
5858

5959
/**
6060
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame)
6161
*/
6262
@new
63-
external make10: (~data: DataView.t, ~init: videoFrameBufferInit) => videoFrame = "VideoFrame"
63+
external fromDataView: (~data: DataView.t, ~init: videoFrameBufferInit) => videoFrame = "VideoFrame"
6464

6565
/**
6666
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/VideoFrame/allocationSize)

‎src/FileAPI/ReadableStream.res‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,6 @@ open FileAPI
66
@new
77
external make: unit => readableStream<array<int>> = "ReadableStream"
88

9-
/**
10-
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream)
11-
*/
12-
@new
13-
external make2: unit => unknown = "ReadableStream"
14-
15-
/**
16-
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream)
17-
*/
18-
@new
19-
external make3: unit => unknown = "ReadableStream"
20-
219
/**
2210
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ReadableStream/cancel)
2311
*/

‎src/MediaCaptureAndStreamsAPI/MediaStream.res‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ external make: unit => mediaStream = "MediaStream"
1010
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/MediaStream)
1111
*/
1212
@new
13-
external make2: mediaStream => mediaStream = "MediaStream"
13+
external fromStream: mediaStream => mediaStream = "MediaStream"
1414

1515
/**
1616
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/MediaStream)
1717
*/
1818
@new
19-
external make3: array<mediaStreamTrack> => mediaStream = "MediaStream"
19+
external fromTracks: array<mediaStreamTrack> => mediaStream = "MediaStream"
2020

2121
include EventTarget.Impl({type t = mediaStream})
2222

‎src/WebAudioAPI/OfflineAudioContext.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ external make: offlineAudioContextOptions => offlineAudioContext = "OfflineAudio
1212
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/OfflineAudioContext)
1313
*/
1414
@new
15-
external make2: (~numberOfChannels: int, ~length: int, ~sampleRate: float) => offlineAudioContext =
15+
external makeWithParams: (~numberOfChannels: int, ~length: int, ~sampleRate: float) => offlineAudioContext =
1616
"OfflineAudioContext"
1717

1818
/**

‎src/WebSocketsAPI/WebSocket.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ external make: (~url: string, ~protocols: string=?) => webSocket = "WebSocket"
1111
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/WebSocket)
1212
*/
1313
@new
14-
external make2: (~url: string, ~protocols: array<string>=?) => webSocket = "WebSocket"
14+
external makeWithProtocols: (~url: string, ~protocols: array<string>=?) => webSocket = "WebSocket"
1515

1616
include EventTarget.Impl({type t = webSocket})
1717

0 commit comments

Comments
 (0)