Skip to content

fix: add .catch() to promise chains - #1688

Closed
saurabhhhcodes wants to merge 1 commit into
reframe-oss:mainfrom
saurabhhhcodes:fix/reframe-2731
Closed

saurabhhhcodes wants to merge 1 commit into
reframe-oss:mainfrom
saurabhhhcodes:fix/reframe-2731

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

This fix improves error handling to prevent silent failures.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @saurabhhhcodes

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix labels Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. ✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@magic-peach

Copy link
Copy Markdown
Collaborator

Hi @saurabhhhcodes — thanks for all the fixes you've been sending to Reframe; several of them are genuinely useful and I want to get those merged.

I'm closing this one because its diff is identical to #1683, which you also have open. There are 34 open PRs from you containing this same one-line change under different titles, so I'm keeping #1683 and closing the rest — otherwise they'd all conflict with each other the moment one merges.

Going forward, could you please open one PR per distinct change, and link the issue it closes? A single PR that fixes five small things is much easier for me to review and merge than five PRs that fix the same one thing. Reviewing near-identical PRs is what's kept the queue from moving, and I'd rather spend that time on your substantive fixes.

Thanks — and please do keep contributing 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants