Simplify intentional word splitting in workflows

Author: AlexWaygood

.github/workflows/daily.yml

@@ -85,28 +85,26 @@ jobs:
         shell: bash
         run: |
           PACKAGES=$(python tests/get_stubtest_system_requirements.py)
-          PACKAGE_ARGS=()
-          while IFS= read -r package; do
-            PACKAGE_ARGS+=("$package")
-          done <<< "$PACKAGES"
 
+          # System package names contain no whitespace or glob characters, so word splitting is intentional.
+          # shellcheck disable=SC2086
           if [ "${{ runner.os }}" = "Linux" ]; then
             if [ -n "$PACKAGES" ]; then
               printf 'Installing APT packages:\n'
-              printf '  %s\n' "${PACKAGE_ARGS[@]}"
-              sudo apt-get update -q && sudo apt-get install -qy "${PACKAGE_ARGS[@]}"
+              printf '  %s\n' $PACKAGES
+              sudo apt-get update -q && sudo apt-get install -qy $PACKAGES
             fi
           else
             if [ "${{ runner.os }}" = "macOS" ] && [ -n "$PACKAGES" ]; then
               printf 'Installing Homebrew packages:\n'
-              printf '  %s\n' "${PACKAGE_ARGS[@]}"
-              brew install -q "${PACKAGE_ARGS[@]}"
+              printf '  %s\n' $PACKAGES
+              brew install -q $PACKAGES
             fi
 
             if [ "${{ runner.os }}" = "Windows" ] && [ -n "$PACKAGES" ]; then
               printf 'Installing Chocolatey packages:\n'
-              printf '  %s\n' "${PACKAGE_ARGS[@]}"
-              choco install -y "${PACKAGE_ARGS[@]}"
+              printf '  %s\n' $PACKAGES
+              choco install -y $PACKAGES
             fi
           fi
       - name: Run stubtest

.github/workflows/stubtest_third_party.yml

@@ -65,30 +65,27 @@ jobs:
       - name: Install required system packages
         shell: bash
         run: |
+          # System package and stub directory names contain no whitespace or glob characters; split both lists into arguments.
+          # shellcheck disable=SC2086
           if [ -n "$STUBS" ]; then
-            read -r -a STUB_ARGS <<< "$STUBS"
-            PACKAGES=$(python tests/get_stubtest_system_requirements.py "${STUB_ARGS[@]}")
-            PACKAGE_ARGS=()
-            while IFS= read -r package; do
-              PACKAGE_ARGS+=("$package")
-            done <<< "$PACKAGES"
+            PACKAGES=$(python tests/get_stubtest_system_requirements.py $STUBS)
             if [ "${{ runner.os }}" = "Linux" ]; then
               if [ -n "$PACKAGES" ]; then
                 printf 'Installing APT packages:\n'
-                printf '  %s\n' "${PACKAGE_ARGS[@]}"
-                sudo apt-get update -q && sudo apt-get install -qy "${PACKAGE_ARGS[@]}"
+                printf '  %s\n' $PACKAGES
+                sudo apt-get update -q && sudo apt-get install -qy $PACKAGES
               fi
             else
               if [ "${{ runner.os }}" = "macOS" ] && [ -n "$PACKAGES" ]; then
                 printf 'Installing Homebrew packages:\n'
-                printf '  %s\n' "${PACKAGE_ARGS[@]}"
-                brew install -q "${PACKAGE_ARGS[@]}"
+                printf '  %s\n' $PACKAGES
+                brew install -q $PACKAGES
               fi
 
               if [ "${{ runner.os }}" = "Windows" ] && [ -n "$PACKAGES" ]; then
                 printf 'Installing Chocolatey packages:\n'
-                printf '  %s\n' "${PACKAGE_ARGS[@]}"
-                choco install -y "${PACKAGE_ARGS[@]}"
+                printf '  %s\n' $PACKAGES
+                choco install -y $PACKAGES
               fi
             fi
           fi
@@ -97,15 +94,16 @@ jobs:
         run: |
           if [ -n "$STUBS" ]; then
             echo "Testing $STUBS..."
-            read -r -a STUB_ARGS <<< "$STUBS"
 
             if [ "${{ runner.os }}" = "Linux" ]; then
               PYTHON_EXECUTABLE="xvfb-run python"
             else
               PYTHON_EXECUTABLE="python"
             fi
 
-            $PYTHON_EXECUTABLE tests/stubtest_third_party.py --ci-platforms-only "${STUB_ARGS[@]}"
+            # Stub directory names contain no whitespace or glob characters, so word splitting is intentional.
+            # shellcheck disable=SC2086
+            $PYTHON_EXECUTABLE tests/stubtest_third_party.py --ci-platforms-only $STUBS
           else
             echo "Nothing to test"
           fi

.github/workflows/tests.yml

@@ -63,14 +63,12 @@ jobs:
       - name: Install required APT packages
         run: |
           PACKAGES=$(python tests/get_stubtest_system_requirements.py)
+          # System package names contain no whitespace or glob characters, so word splitting is intentional.
+          # shellcheck disable=SC2086
           if [ -n "$PACKAGES" ]; then
-            PACKAGE_ARGS=()
-            while IFS= read -r package; do
-              PACKAGE_ARGS+=("$package")
-            done <<< "$PACKAGES"
             printf 'Installing APT packages:\n'
-            printf '  %s\n' "${PACKAGE_ARGS[@]}"
-            sudo apt-get update -q && sudo apt-get install -qy "${PACKAGE_ARGS[@]}"
+            printf '  %s\n' $PACKAGES
+            sudo apt-get update -q && sudo apt-get install -qy $PACKAGES
           fi
       - name: Run mypy_test.py
         run: python ./tests/mypy_test.py --platform=${{ matrix.platform }} --python-version=${{ matrix.python-version }}
@@ -199,14 +197,12 @@ jobs:
       - name: Install required APT packages
         run: |
           PACKAGES=$(python tests/get_stubtest_system_requirements.py)
+          # System package names contain no whitespace or glob characters, so word splitting is intentional.
+          # shellcheck disable=SC2086
           if [ -n "$PACKAGES" ]; then
-            PACKAGE_ARGS=()
-            while IFS= read -r package; do
-              PACKAGE_ARGS+=("$package")
-            done <<< "$PACKAGES"
             printf 'Installing APT packages:\n'
-            printf '  %s\n' "${PACKAGE_ARGS[@]}"
-            sudo apt-get update -q && sudo apt-get install -qy "${PACKAGE_ARGS[@]}"
+            printf '  %s\n' $PACKAGES
+            sudo apt-get update -q && sudo apt-get install -qy $PACKAGES
           fi
       - name: Create an isolated venv for testing
         run: uv venv .venv