Repository navigation
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
Optional list and string inputs are now typed Input<T | undefined> rather than Input<T> | undefined, so the surrounding signatures no longer accept them. Widen the affected signatures and guard the resolved values instead of casting. The one behaviour change is in getRecommendedAMI: version now falls back with `version ?? clusterVersion`. Previously an args.version that resolved to undefined was passed straight into ssmParameterName, producing a malformed SSM parameter path.
28908cb to
76da1c9
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
@pulumi/providers hi, friendly bump — this is waiting on /run-acceptance-tests (open since Aug 27) |
|
@corymhall hi. its been a month since this pr. if u can take a look i would be glad. many new features dosent exists here and this is really a small fix to keep the renovate bot keep working after that. |
|
Hi @corymhall, friendly bump. This only needs a maintainer to run /run-acceptance-tests. It keeps @pulumi/aws current and fixes the nodegroup input types, so Renovate can keep working here. Thanks! |
TL;DR
@pulumi/awsv7.30.0 movedundefinedinside theInput<>wrapper for optional inputsSDK-wide.
nodegroup.tsdoesn't compile against that, which is why the bump in #2209 failsbuild_provider. This PR does the bump and the type fix together so CI stays green.Proposed changes
Bumps
@pulumi/awsfrom 7.25.0 to 7.43.0 (same bump as #2209) and fixes the TypeScriptcompile errors that bump surfaces.
Why the bump alone fails
@pulumi/awsv7.30.0 changed optional inputs SDK-wide, movingundefinedinside theInput<>wrapper:This is codegen-wide, not EKS-specific —
ec2/instance,ecs/serviceandrds/instancepick up the same shape in v7.30.0.
Input<T> | undefinedis assignable once null-checked;Input<T | undefined>is not, becausethe
undefinedsurvives into thePromise/Outputbranch. SinceManagedNodeGroupOptionsderives from
aws.eks.NodeGroupArgs,tscfails with 7 errors innodes/nodegroup.ts(lines 2002, 2079, 2159, 2274, 2360, 2372, 2387) — which is what fails
build_provideron#2209 today, in turn skipping the
testjob.The fix
Widen the affected signatures in
nodes/instances.tsandnodes/nodegroup.tsto accept thenew shape and guard the resolved values, rather than casting the
undefinedaway.One behaviour change beyond types, in
getRecommendedAMI:versionnow resolves withversion ?? clusterVersion. Previously anargs.versionthat was truthy as anOutputbutresolved to
undefinedwas passed straight intossmParameterName, producing a malformedSSM parameter path.
These changes are backwards-compatible — the source still compiles against 7.25.0.
Verification
tsc— clean against both 7.25.0 and 7.43.0yarn test— 417 tests / 10 suites / 18 snapshots passyarn check-duplicate-deps— cleanRelated issues
@pulumi/aws7.42.0+, so this bump is a prerequisite for that. Split out of Support advanced Kubernetes control plane configuration #2368 to keep the dependency
change reviewable on its own.