Skip to content

Update dependency @pulumi/aws to v7.43.0 and fix nodegroup input types - #2371

Open
ranyhb wants to merge 2 commits into
pulumi:masterfrom
ranyhb:ranyhb/bump-aws-7.43
Open

ranyhb wants to merge 2 commits into
pulumi:masterfrom
ranyhb:ranyhb/bump-aws-7.43

Conversation

@ranyhb

@ranyhb ranyhb commented Aug 27, 2026 •

Copy link
Copy Markdown

TL;DR

@pulumi/aws v7.30.0 moved undefined inside the Input<> wrapper for optional inputs
SDK-wide. nodegroup.ts doesn't compile against that, which is why the bump in #2209 fails
build_provider. This PR does the bump and the type fix together so CI stays green.

Proposed changes

Bumps @pulumi/aws from 7.25.0 to 7.43.0 (same bump as #2209) and fixes the TypeScript
compile errors that bump surfaces.

Why the bump alone fails

@pulumi/aws v7.30.0 changed optional inputs SDK-wide, moving undefined inside the
Input<> wrapper:

-    amiType?:       pulumi.Input<string>;
+    amiType?:       pulumi.Input<string | undefined>;
-    instanceTypes?: pulumi.Input<pulumi.Input<string>[]>;
+    instanceTypes?: pulumi.Input<pulumi.Input<string>[] | undefined>;
-    taints?:        pulumi.Input<pulumi.Input<inputs.eks.NodeGroupTaint>[]>;
+    taints?:        pulumi.Input<pulumi.Input<inputs.eks.NodeGroupTaint>[] | undefined>;
-    version?:       pulumi.Input<string>;
+    version?:       pulumi.Input<string | undefined>;

This is codegen-wide, not EKS-specific — ec2/instance, ecs/service and rds/instance
pick up the same shape in v7.30.0.

Input<T> | undefined is assignable once null-checked; Input<T | undefined> is not, because
the undefined survives into the Promise/Output branch. Since ManagedNodeGroupOptions
derives from aws.eks.NodeGroupArgs, tsc fails with 7 errors in nodes/nodegroup.ts
(lines 2002, 2079, 2159, 2274, 2360, 2372, 2387) — which is what fails build_provider on
#2209 today, in turn skipping the test job.

The fix

Widen the affected signatures in nodes/instances.ts and nodes/nodegroup.ts to accept the
new shape and guard the resolved values, rather than casting the undefined away.

One behaviour change beyond types, in getRecommendedAMI: version now resolves with
version ?? clusterVersion. Previously an args.version that was truthy as an Output but
resolved to undefined was passed straight into ssmParameterName, producing a malformed
SSM parameter path.

These changes are backwards-compatible — the source still compiles against 7.25.0.

Verification

  • tsc — clean against both 7.25.0 and 7.43.0
  • yarn test — 417 tests / 10 suites / 18 snapshots pass
  • yarn check-duplicate-deps — clean

Related issues

@github-actions

Copy link
Copy Markdown
Contributor

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

pulumi-renovate Bot and others added 2 commits September 27, 2026 08:29
Optional list and string inputs are now typed Input<T | undefined> rather than
Input<T> | undefined, so the surrounding signatures no longer accept them. Widen
the affected signatures and guard the resolved values instead of casting.

The one behaviour change is in getRecommendedAMI: version now falls back with
`version ?? clusterVersion`. Previously an args.version that resolved to
undefined was passed straight into ssmParameterName, producing a malformed SSM
parameter path.
@ranyhb
ranyhb force-pushed the ranyhb/bump-aws-7.43 branch from 28908cb to 76da1c9 Compare September 27, 2026 05:30
@github-actions

Copy link
Copy Markdown
Contributor

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@ranyhb

ranyhb commented Oct 21, 2026 •

Copy link
Copy Markdown
Author

@pulumi/providers hi, friendly bump — this is waiting on /run-acceptance-tests (open since Aug 27)
or if u want u can fix that pr #2209

@ranyhb

ranyhb commented Oct 29, 2026

Copy link
Copy Markdown
Author

@corymhall hi. its been a month since this pr. if u can take a look i would be glad. many new features dosent exists here and this is really a small fix to keep the renovate bot keep working after that.

@ranyhb

ranyhb commented Nov 11, 2026

Copy link
Copy Markdown
Author

Hi @corymhall, friendly bump. This only needs a maintainer to run /run-acceptance-tests. It keeps @pulumi/aws current and fixes the nodegroup input types, so Renovate can keep working here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant