JvAppDBStorage without a DataSource

[tothpaul]

Hello,

I encountered a regression after updating JVCL. One of my applications uses JvAppDBStorage with custom read/write events, so it does not use the DataSource property (for historical reasons, of course).

In the latest update, the DataSource <> nil checks were removed, causing my application to crash, for example, in GetPhysicalReadOnly.

Of course, I shouldn't be using JvAppDBStorage if I don't use a DataSource, but JvAppStorage does not provide custom read/write events. :)

So, before I remove these components from my application, is there something I might have missed?

Thanks.

[obones]

Hello,

I had a look at the log for JvAppDBStorage.pas and I could not find anything related in the last 5 commits that go as far back as 2009 so I'm surprised at your findings.

Can you check if it's not something you added in your own copy?

[jfudickar]

I'm also a little bit surprised.
In which function domain expect this check.
Maybe it's something we can add.
Or we may add the events to the core component.
You are also allowed to make a pull request to get this included :-)
Regards
Jens

[tothpaul]

Oh yes ! my bad, it was a change I've made back in 2018 !
in ReadValue, GetPhysicalReadOnly and ValueExists

the purpose was to keep the logic of AppStorage with my custom read/write methods

Thanks