Repository navigation
Commit fc4f20c
1.6.44 item 2 fix: the HEAD guard must not fail on a version the floor permits
A DEFECT I SHIPPED, found by the ops seat mirroring this tree the way the
standard actually requires.
`test_the_package_has_not_yet_taken_over_the_head_fix` asserted
`resolved < (2, 9, 4)` as a HARD FAILURE, so that it would "go red by itself
when the package catches up". It does. But this fork's requirements line is a
`>=2.8.0` FLOOR, and a fresh venv resolves 2.10.0 TODAY — so the assertion
fails on every CI leg from the first run. A reminder that turns a permitted
dependency resolution into a red build is not a reminder; it is an outage with
a helpful message.
WHY MY OWN CLEAN-CLONE RUN COULD NOT SEE IT, which is the more useful half.
I cloned the tree but reused this seat's .venv, which holds 2.8.0 from an
earlier install. The clone tests the CODE; only a FRESH venv from
requirements.txt tests the RESOLUTION, and CI does both. A `>=` floor makes
those two different questions — item 10 says exactly that about reporting, and
I did not apply it to my own verification.
REPRODUCED AND FIXED ON A FRESH 3.12 VENV RESOLVING dimll 2.10.0:
before: 1 failed, 18 passed (exit 1) <- ops' finding, reproduced
after: 20 passed, 1 xfailed (exit 0)
TWO REGIMES, ONE POSTURE. Below 2.9.4 the shim is LOAD-BEARING; at or above it
the package answers HEAD at the router and the shim is REDUNDANT — not wrong,
not broken, and the parity table is 15/15 either way. The shim stays INSTALLED
in both, because it is retired by the PIN ROUND (1.6.45) on a re-measured
parity table, never by whichever version a resolver happened to pick.
The "shim still required" clause is now an xfail rather than an assert, so the
day the package takes over is VISIBLE in CI as an XFAIL transition instead of a
red build; the resolved version and which mechanism answered HEAD are recorded
as test properties and printed, so somebody reads it when the pin round comes.
DIVERGENCES 17 carries the same two-regime sentence.
ONE PROCESS NOTE: my first attempt to verify this ran pytest in a venv where
I had installed it under `--no-deps`, so both the before and after runs exited
1 on a missing `pluggy`. Read carelessly, that would have "confirmed" the bug
and then "confirmed" the fix failing, from a packaging error of my own. Exit
codes were re-taken after installing pytest properly.
Seat venv (dimll 2.8.0): 578 passed, 3 skipped, exit 0 — gated.
Fresh venv (dimll 2.10.0), this file: 20 passed, 1 xfailed, exit 0.
flake8 on CI exact line: exit 0, 0 lines.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014QRqmPVfHxJQC41PaYDnqb1 parent 2808e92 commit fc4f20c
2 files changed
Lines changed: 131 additions & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
428 | 428 | | |
429 | 429 | | |
430 | 430 | | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
435 | 455 | | |
436 | 456 | | |
437 | 457 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
101 | 99 | | |
102 | 100 | | |
103 | 101 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
113 | 107 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
122 | 204 | | |
123 | 205 | | |
124 | 206 | | |
| |||
0 commit comments