Fix more deprecations in tests, use attributes for phpunit. Enable one commented test

Author: williamdes

tests/TestCase/Model/Table/IncidentsTableTest.php

@@ -5,6 +5,7 @@
 use App\Model\Table\IncidentsTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use ReflectionMethod;
 
 use function count;
@@ -492,16 +493,16 @@ public function testCreateIncidentFromBugReport(): void
     }
 
     /**
-     * @dataProvider versionsStripping
      * @param string $version  The version
      * @param string $expected The expected version
      */
+    #[DataProvider('versionsStripping')]
     public function testStripversion(string $version, string $expected): void
     {
         $this->assertEquals($expected, IncidentsTable::getStrippedPmaVersion($version));
     }
 
-    public function versionsStripping(): array
+    public static function versionsStripping(): array
     {
         return [
             [

tests/TestCase/Model/Table/NotificationsTableTest.php

@@ -2,7 +2,7 @@
 
 namespace App\Test\TestCase\Model\Table;
 
-use App\Model\Table\NotificationTable;
+use App\Model\Table\NotificationsTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;
 
@@ -13,7 +13,7 @@
  */
 class NotificationsTableTest extends TestCase
 {
-    protected NotificationTable $Notification;
+    protected NotificationsTable $Notifications;
 
     /**
      * Fixtures.

tests/TestCase/Model/Table/ReportsTableTest.php

@@ -43,16 +43,17 @@ public function testGetIncidents(): void
         //$this->assertEquals(count($incidents), 2);
     }
 
-    //TODO: will do after related to fix
-    //public function testGetRelatedReports() {
-    //    $this->Reports->id = 2;
-    //    $reports = $this->Reports->getRelatedReports();
-    //    $this->assertEquals(count($reports), 0);
-    //
-    //    $this->Report->read(null, 4);
-    //    $reports = $this->Report->getRelatedReports();
-    //    $this->assertEquals(count($reports), 1);
-    //}
+    public function testGetRelatedReports(): void
+    {
+        $this->Reports->id = 2;
+        $reports = $this->Reports->getRelatedReports()->all();
+        $this->assertEquals(count($reports), 0);
+
+        $this->markTestIncomplete('Does not work anymore');
+        $this->Reports->read(null, 4);
+        $reports = $this->Reports->getRelatedReports()->all();
+        $this->assertEquals(count($reports), 1);
+    }
 
     /**
      * Test for getIncidentsWithDescription

tests/TestCase/View/Helper/ReportsHelperTest.php

@@ -2,14 +2,14 @@
 
 namespace App\Test\TestCase\View\Helper;
 
-use App\Model\Table\ReportsTable;
 use App\View\Helper\ReportsHelper;
 use Cake\TestSuite\TestCase;
 use Cake\View\View;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class ReportsHelperTest extends TestCase
 {
-    protected ReportsTable $Reports;
+    protected ReportsHelper $Reports;
 
     public function setUp(): void
     {
@@ -23,7 +23,7 @@ public function setUp(): void
      *
      * @return array array data for testLinkToReport
      */
-    public function providerForTestLinkToReport(): array
+    public static function providerForTestLinkToReport(): array
     {
         return [
             [
@@ -60,10 +60,10 @@ public function providerForTestLinkToReport(): array
     }
 
     /**
-     * @dataProvider providerForTestLinkToReport
      * @param array  $report   The report
      * @param string $expected The expected
      */
+    #[DataProvider('providerForTestLinkToReport')]
     public function testLinkToReport(array $report, string $expected): void
     {
         $link = $this->Reports->linkToReport($report);
@@ -79,7 +79,7 @@ public function testLinkToReport(array $report, string $expected): void
      *
      * @return array array data to testCreateReportsLinks
      */
-    public function providerForTestCreateReportsLinks(): array
+    public static function providerForTestCreateReportsLinks(): array
     {
         return [
             [
@@ -116,10 +116,10 @@ public function providerForTestCreateReportsLinks(): array
     }
 
     /**
-     * @dataProvider providerForTestCreateReportsLinks
      * @param array  $reports  The reports
      * @param string $expected The expected reports
      */
+    #[DataProvider('providerForTestCreateReportsLinks')]
     public function testCreateReportsLinks(array $reports, string $expected): void
     {
         $links_str = $this->Reports->createReportsLinks($reports);